search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Namex: NR expiry should have a transaction #23059

Open severinbeauvais opened 1 month ago

severinbeauvais commented 1 month ago

Here are the transactions for an example Name Request (in Name Examination UI):

image.png

https://dev.namex.bcregistry.gov.bc.ca/transactions?nr=2889280

As you can see, there is no transaction for the status change from Approved to Expiry. We can see that this NR is expired but we don't know when that actually happened. (In this example, we can maybe deduce that it was set to Expired on Aug 29 because it was approved on Aug 29 and is expired today, Aug 30, but normally there would be 56 days between those events so we wouldn't know for sure.)

In any case, an exact date and time that the NR was set to Expired would be helpful to see in the transaction history.

Similarly, an expiry extension (via API call from LEAR) should have a transaction. At the moment, we cannot tell if the NR expiry was extended (ie, to ensure that a future-effective incorporation/registration/amalgamation/continuation-in will not fail due to the NR expiring). This part may be blocked by #23050 (whereby the expiry extension isn't actually happening right now).

eve-git commented 3 weeks ago

the transaction of expired is like:

image.png
eve-git commented 3 weeks ago

Ready to test in both DEV and TEST environments.

severinbeauvais commented 3 weeks ago

Test Notes

I just created the following NR, approved it, and set its expiry to today (Sept 11).

https://dev.namex.bcregistry.gov.bc.ca/examine?nr=6870158

Tomorrow, I will check the transaction history to verify the Expired entry.

severinbeauvais commented 3 weeks ago

Looks good!

image

Mihai-QuickSilverDev commented 3 weeks ago
image.png
Mihai-QuickSilverDev commented 3 weeks ago