Edit UI: Cont. In company can only alter to another Cont. In type company (C, CBEN, CCC, CUL)

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 58 forks source link

Edit UI: Cont. In company can only alter to another Cont. In type company (C, CBEN, CCC, CUL) #23092

Open severinbeauvais opened 2 weeks ago

severinbeauvais commented 2 weeks ago

See also #21669.

In #22479, a conversion was applied so that a C company can alter to a regular type (BC, BEN, CC, ULC). This was incorrect. THIS ticket is to change this behaviour. See this PR that made the original change.

Scenarios:

[x] Change the business type
[x] Prompt for Name Request change if needed (see table below)
[ ] Verify filing type codes -- see 19528 for codes

Here are the test scenarios that were performed when the company type change feature was implemented:

severinbeauvais commented 2 weeks ago

deleted obsolete comment

vikas-gov commented 2 weeks ago

deleted obsolete comment

OlgaPotiagalova commented 1 week ago

~Confirmed with the Business that C company should be converted to BC, BEN, CC, ULC. So the C prefix in the company type is not carried over in the alteration process~ see comments below

severinbeauvais commented 1 week ago

deleted obsolete comment

vysakh-menon-aot commented 1 week ago

@OlgaPotiagalova I assume there won't be any change in the identifier (C1234567)

Mihai-QuickSilverDev commented 1 week ago

@vysakh-menon-aot The identifier changes. As per Olga - "So the C prefix in the company type is not carried over in the alteration process". By extrapolation, we do not identify BC companies with a C number.

vysakh-menon-aot commented 1 week ago

@Mihai-QuickSilverDev can we verify that in colin once?

OlgaPotiagalova commented 1 week ago

I assume, the identifier shouldn't be affected. @Mihai-QuickSilverDev, could you please confirm this using COLIN data. Thank you.

Mihai-QuickSilverDev commented 1 week ago

[ ] SOFI UI only has type changes from BC LTD to BC ULC and CCC.
[ ] I have asked Sid to see if he could find an example of a continued in company changing its type.

severinbeauvais commented 1 week ago

There are still conflicting requirements. This will be discussed with the business on Tuesday, and then we can figure out what code needs to change.

per @Mihai-QuickSilverDev and @OlgaPotiagalova

Mihai-QuickSilverDev commented 1 week ago

[ ] Regarding the "like for like" development principle, these are the verified requirements:
Once created in BC through a Continuation In filing, the company will continue to act as a Continued In company for the duration of its existence. For example - from C to CUL or CCC.
When changing its type, it would adopt the Continued In version of the type they are changing into
The identifier will always continue to be Cxxxxxxx
[ ] Final confirmation of this with the Business on Tuesday, September 17, 2024.

vikas-gov commented 3 days ago

need further analysis and review before prioritizing

severinbeauvais commented 3 days ago

deleted obsolete comment

Mihai-QuickSilverDev commented 3 days ago

[ ] My requirements above from 5 days ago were confirmed as such by the Business.
[ ] I also have added in the description the exhaustive list of possible type changes combunations.
[ ] Requirements for this ticket are now complete.
[ ] On to the developers.

severinbeauvais commented 3 days ago

It looks like the "you need a Name Request to make this change" code is already in place, so theoretically this functionality should work correctly for continued in businesses (C, etc) as well as regular businesses (BC, etc). I am going to assume that this current functionality is satisfactory and no changes to it are needed.

Example:

https://dev.edit.business.bcregistry.gov.bc.ca/BC0883068/alteration?accountid=3040

ArwenQin commented 1 day ago

The issues previously in #23076 are solved in this ticket. The issue that unable to alter the company for valid legal types (Cont in ULC to benefit company) was for Cont in businesses only. Now fixed, Cont in can only be altered to a Cont in.