bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Namerequest UI: Unable to request a Name Change NR for a limited restored company #23332

Open Mihai-QuickSilverDev opened 2 months ago

Mihai-QuickSilverDev commented 2 months ago

For a company in limited restoration that is trying to convert to a full restoration, Name Request needs to allow the Name Change NR for that entity. Right now this is not happening - Name Request UI is only searching for historical companies. See insert below.

To Do List:

image.png

cc @ozamani9gh @OlgaPotiagalova @severinbeauvais

severinbeauvais commented 2 months ago

I don't think Business Search (which is used here) knows whether a business is in LR. It only knows if the business is Active or Historical.

Should we open up this search request (via parameters) to return all Active and Historical businesses?

severinbeauvais commented 2 months ago

Explanation

COLIN expects to use a Restoration NR to do a full restoration, limited restoration extension, or limited restoration conversion.

However, Namerequest UI will not find the limited restored NR because it looks for historical business -- and the subject business is no longer historical; it's active (for a limited time).

severinbeauvais commented 2 months ago

Potential Solution

~Since Namerequest UI needs to behave differently in Prod (for COLIN purposes) and in Dev/Test (for BCROS purposes), we could create a feature flag for this.~

~What we're asking for is that, in Prod, Namerequest UI finds an active business (as well as historical businesses) when creating a restoration NR. This removes a "guard" we put in place (since it doesn't make sense to restore an active business, but COLIN wants it anyways). Are we OK with this?~

Update: see my comment below.

@OlgaPotiagalova @Mihai-QuickSilverDev

EPortman commented 2 weeks ago

Hi @severinbeauvais .

Could you clarify the need for differing behaviors in the dev/test environments compared to production for the NameRequest UI? I understand from your earlier messages that in PROD, we aim to enable restoration name requests for active businesses, potentially allowing name changes to convert into a full restoration. However, in the DEV and TEST, this behavior is restricted.

My question is, what is the rationale behind this discrepancy? Specifically, why does the NameRequest UI need to behave differently when interfacing with BCROS in the non-production environments?

severinbeauvais commented 2 weeks ago

My comment doesn't make sense (to me) any more. I think I confused COLIN/LEAR with Prod/Test...

The original idea was for Namerequest UI to behave differently for COLIN and for LEAR, but when a user is trying to create a restoration NR, we don't know if it's for a COLIN or LEAR business.

I think we need to open up the business search (in Namerequest UI), for restorations, to both Historical and Active businesses. This might cause some people to accidentally create a restoration NR for an actual active business (which is useless), but it will also allow people to create a restoration NR for a limited-restoration business (which is technically active, not historical).

@Mihai-QuickSilverDev @OlgaPotiagalova , do you agree to proceed with this?

ozamani9gh commented 6 days ago

@Mihai-QuickSilverDev determine specs needed and related to an operational issue.