bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Legal API - Allowable Actions (Notice of Withdrawal) #23348

Closed JazzarKarim closed 3 weeks ago

JazzarKarim commented 1 month ago

TODOs

AimeeGao commented 3 weeks ago

After discussing with Argus and Hongjing, we have decided to focus on the Notice of Withdrawal logic for existing businesses in this ticket. The temporary business scenario will be excluded for now.

AimeeGao commented 3 weeks ago

Notes for QA - Notice of Withdrawal (NoW) for Existing Businesses

Note: As discussed with Argus and Hongjing, the temporary business scenario requires further design and investigation. Due to priorities, work on the Notice of Withdrawal (NoW) for temporary businesses is currently on hold. This ticket focuses only on implementing allowable actions for existing businesses.

Step 1: Ensure that the allowable actions for BC, BEN, CC, ULC company types (including their Continued In versions: C, CCC, CBEN & CUL).

Step 2: We can use the BC company type for testing in the dev environment. The returned results can be viewed via the get-business API:

GET: {{url}}/api/v2/businesses/:id

  1. No FED Filings For a business that is active without any FED filings, confirm that the NoW action is blocked.

    image.png
  2. Frozen Business For a business that is active but frozen, the NoW should also be blocked.

    image.png
  3. Pending or Draft Filings If a business has a pending or draft filing, the NoW should be disallowed.

    image.png
  4. Ensure the NoW is staff-only

    image.png
  5. Valid request

For businesses that meet all the necessary conditions (e.g., have FED filings, are not frozen, and have no pending or draft filings, business are active, and the user is a staff member), the NoW should appear in the list of allowable actions.

image.png

Feel free to reach out if you have any questions or need assistance with the testing steps.

AimeeGao commented 3 weeks ago

Updated in the spreadsheet that the current Notice of Withdrawal (NoW) action is only applicable to existing businesses.

vishnup0422 commented 3 weeks ago

Created a new business of type ULC: BC0883614

Sent a GET request(https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0883614) to see the allowedActions inside the response. noticeOfWithdrawal is not visible as there are no FED Filings.

Performed Address change filing

Screenshot 2024-10-08 at 8.51.53 PM.png

Sent a GET request to retrieve the business again and noticeOfWithdrawal is visible in the allowedActions.

Screenshot 2024-10-08 at 8.52.18 PM.png

It displays viewAll as false as its only for staff.

Performed a new filing to Freeze the business.

image.png

Send a request again

Notice of withdrawal will not be in the response

image.png

Unfreeze the business and validate the response again.

image.png
vishnup0422 commented 3 weeks ago

When the business has a draft Filing

image.png image.png