search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

LEAR: some Incorporators are linked to the business (but shouldn't be) #23395

Open severinbeauvais opened 3 weeks ago

severinbeauvais commented 3 weeks ago

Impact: Corrections don't go through or incorporator gets ceased accidentally Effort:

While testing something else, it was found that the Incorporator was displayed as a director that could be corrected:

image.png

This is apparently old data from before we changed how parties were linked (in ticket #10494). It seems the old data should have been corrected but wasn't.

There are 542 records in Prod with the incorporator linked to the business instead of the filing. We should also check if any completing parties are linked to the business instead of the filing.

This (apparent) data bug applies to corrections (which are staff-only). Alterations are not affected (because they fetch directors, not all parties).

cc: @vysakh-menon-aot

vysakh-menon-aot commented 3 weeks ago

In PROD we should update business_id to null and map the correct filing_id (incorporationApplication filing id) for the below data

image.png
vikas-gov commented 2 weeks ago

Data migration: Create a check for this scenario.

For this issue, the impacted data can be updated.

severinbeauvais commented 2 weeks ago

Vysakh said that COLIN shouldn't be affected by this data.

Therefore, we only need to perform the data fix in LEAR, and it can be done separately from data migration.

cc: @OlgaPotiagalova

severinbeauvais commented 1 week ago

Mihai says Ops doesn't have the data modeling knowledge to make this data fix, so @vysakh-menon-aot should do it.