bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Filings UI: handle multiple draft states and other changes #23520

Closed severinbeauvais closed 3 weeks ago

severinbeauvais commented 1 month ago

New Description

Old Description

At a minimum:

New design: Continuation: Dashboard States

severinbeauvais commented 1 month ago

Reason in gray block:

image.png
vikas-gov commented 1 month ago

https://www.figma.com/design/rNe2jn8wyFykKRzwiBo6ar/Continuation-In-V6?node-id=100-4595

severinbeauvais commented 1 month ago

This ticket is blocked until we meet with BTR team, on Oct 8 at 3pm, to decide how to handle this Dependency ticket.

severinbeauvais commented 1 month ago

I have unblocked this ticket as we can now work on it.

I reduced the estimate as we are now doing the minimum to permit the new continuation in designs. (It may still be high depending on your definition of "mininum").

severinbeauvais commented 1 month ago

I merged Arwen's code changes. If there are remaining changes, they can be done in another PR or another ticket.

UX peeps, please have a look at the changes.

jacqueline-williams-549 commented 1 month ago

@ArwenQin

severinbeauvais commented 1 month ago

OK, moving back to In Progress for further changes.

severinbeauvais commented 1 month ago

This ticket (Filings UI) is the dashboard. Do you mean that we should change some language on the "registry" (MBR)?

I think we can make the language changes in this ticket (no need for a new ticket).

jacqueline-williams-549 commented 1 month ago

We decided to keep the language on the MBR as is, but to update the language on the dashboard so the card says 'authorization' instead of 'application' (when the user is still on step 0). Can you confirm this @janisrogers ? Yes this is confirmed.

Screenshot 2024-10-15 at 10.34.37 AM.png
severinbeauvais commented 1 month ago

Sounds good. Yes, we can make the text changes in this ticket.

severinbeauvais commented 1 month ago

Do you want the BC Registries contact info on certain cards, like the Change Requested one above?

jacqueline-williams-549 commented 4 weeks ago

The authorization pending review state does also show contact info.

Designs are here: https://www.figma.com/design/rNe2jn8wyFykKRzwiBo6ar/Continuation-In-V6?node-id=100-4595

severinbeauvais commented 4 weeks ago

This ticket is more complicated than I expected so I've updated the estimate to 5.

ArwenQin commented 4 weeks ago

FE Application design please see:

image.png

The future effective text and contact info were not in the original design ( https://www.figma.com/design/rNe2jn8wyFykKRzwiBo6ar/Continuation-In-V6?node-id=100-4595&m=dev&focus-id=664-72490) - design is at the bottom

ArwenQin commented 3 weeks ago

@jacqueline-williams-549 Hi Jacqueline, we just finished this ticket, so further UI updates will be in a new ticket. (Exception: if something is broken by this PR then we keep working on it.)

jacqueline-williams-549 commented 3 weeks ago

@ArwenQin Okay that sounds good, thanks Arwen

jacqueline-williams-549 commented 3 weeks ago

SB says: the following comments have been moved to new tickets.

1. Entity Dashboard: Authorization Approved State - Resume the Continuation Application

Entity Dashboard-AuthorizationApproved.png

2. Entity Dashboard: Pending Review State - Button language updated

EntityDashboard-PendingReview.png

3. Entity Dashboard: Rejected State - Wanting to make the 'Rejected' text bold so that it passes accessibility standards. Other language updates shown in screenshot. (Sorry there wasn't a design for this earlier - Rejected Authorization Design - Should I put this in another ticket @ArwenQin ?)

EntityDashboard-Rejected.png

4. My Business Registry: Authorization Approved State - Button language updated. When the authorization is approved, on the MBR the button should say "Resume Application"

MBR-AuthorizationApproved-ResumeApplication.png

5. Entity Dashboard: Submit Authorization Modal - Can remove this constraint on the file upload section of the Continuation Authorization?

AuthorizationError-FileUploadConstraints.png
severinbeauvais commented 3 weeks ago

Thanks for the feedback! Can you please move it into a new ticket? Thanks.

jacqueline-williams-549 commented 3 weeks ago

Yes no problem! Moved it here: Entity Dashboard and MBR: Authorization and Application States 23935

severinbeauvais commented 3 weeks ago

Thanks, Jacqueline!

FYI, I broke up 23935 into a couple of other tickets because the changes are in different projects.