search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Verify - Dashboard message for Amalgamation does not include actual date #23873

Open mstanton1 opened 3 days ago

mstanton1 commented 3 days ago

Describe the bug in current situation When a future effective amalgamation is filed, an alert displays. This alert should include the future effective dissolution date. Currently our alert is missing the date value.

Collapsed View

image.png

Expanded View

image.png

Note for Testing: Entities has identified an issue where a future effective amalgamation modal on the Entity Dashboard is displaying the incorrect future effective date. See information from their related ticket #23792 below.

This alert shows a future effective amalgamation date of October 26, 2024. When verifying this fix it will be important to test to ensure the correct date is displaying.

image.png

The actual FE date and time is October 27, 2024 at 11:30 AM.

The data from the Legal API is correct, so this is a UI data conversion bug.

image.png

Link bug to the User Story

Impact of this bug Describe the impact, i.e. what the impact is, and number of users impacted.

Chance of Occurring (high/medium/low/very low)

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?

Steps to Reproduce

  1. select an active corporation (eg, BC0883604)
  2. start an amalgamation from this business (any type)
  3. add another business to the amalgamation (eg, BC0883571)
  4. set the amalgamation date and time to future values (eg, 2024-10-27 11:30AM)
  5. file and pay for the amalgamation filing
  6. reopen the dashboard for either of the amalgamating businesses
  7. observe that an amalgamation alert displays for either business, but the stated date is wrong (ie, October 26, 2024)

Sample businesses from above: https://dev.business.bcregistry.gov.bc.ca/TGZ0btrZLv?filing_id=151534 (the amalgamaTED) https://dev.business.bcregistry.gov.bc.ca/BC0883604 (amalgamaTING no. 1) https://dev.business.bcregistry.gov.bc.ca/BC0883571 (amalgamaTING no. 2)

Actual/ observed behavior/ results As per first screenshot the date in the modal shows a future effective date that is one calendar day earlier than the actual stored date.

Expected behavior The date in the modal should match the date in the database.

Screenshots/ Visual Reference/ Source If applicable, add screenshots to help explain your problem. You an use screengrab.

mstanton1 commented 3 days ago

@gunanagar can you please test this scenario to verify if it is an issue in our new dashboard. Severin has noted steps to reproduce. If you have questions on those I should be able to help.

gunanagar commented 2 days ago

@mstanton1 , tested found some interesting bug in new dashboard. No date is displayed . Pls refer the docamalgamation_testing.docx

gunanagar commented 2 days ago

@mstanton1 New dashboard :

image.png

Current dashboard

image.png
mstanton1 commented 2 days ago

Thank you @gunanagar ! I'll update this ticket to cover adding the date in:) When the ticket is handled it will be really important to check the date stored in the DB to make sure we implement this so it shows correctly.