bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Auth Web staff dashboard: submitter should not be "undefined" #24080

Open severinbeauvais opened 2 weeks ago

severinbeauvais commented 2 weeks ago

The original submitter name shows as "undefined".

The re-submitter name is not even shown.

image.png

The root cause is that we no longer capture the Completing Party as this is an authorization only -- but we do have the submitter's login. (Note that we also don't support multiple submitters.)

Option 1: Show the authorization submitter from the filing's header.submitter property. (Right now this is the encoded login but we could update the review endpoint to provide the decoded name.) We would only be able to display one submitter -- the original one or the latest one. I suggest the latest one as being most useful.

Option 2: Don't show the authorization submitter, since we already don't show it for a resubmission.

severinbeauvais commented 2 weeks ago

Duplicate ticket: #24078

severinbeauvais commented 1 week ago

Also, the line should say "Authorization Submitted" (not Application).

severinbeauvais commented 1 week ago

@jacqueline-williams-549 @janisrogers Please see the description for possible options. Do you have a preference? Thanks!

janisrogers commented 1 week ago

My preference would be option 1, but I am okay with option 2.

severinbeauvais commented 1 week ago

@OlgaPotiagalova Could you please decide whether we should implement option 1 or option 2?

Option 1 is more work (est: 1 for UI, 2 for API) but provides a better experience because it should the submitter name.

Option 2 is almost no work (est: 1 for UI).