search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Create UI: Review and Certify page shows Check mark even when the certify box is unchecked. #24082

Closed riyazuddinsyed closed 2 weeks ago

riyazuddinsyed commented 4 weeks ago

Describe the bug in the current situation When the user clicks "File and Pay" and encounters an error, such as identical names for "Shares" and "Share Series," the UI displays a warning message. Upon clicking "OK" on the warning, the user is redirected to the "Save and Resume" page, with the Stepper indicating Step 5 as still completed.

Steps to reproduce the behavior:

  1. Go to 'https://test.account.bcregistry.gov.bc.ca/'
  2. Start a ULC IA.
  3. In the Share Structure page add a Share Class and Share Series with the same Name.
  4. Now click on "File and Pay"
  5. Observe that the UI throws a dialog saying that the Share series and share class name is the same.
  6. Now click "Ok"
  7. Observve that when the user returns back to Step 5 notice that the stepper shows green check mark indicating the page is complete while the Certify checkbox is not clicked

Screenshots/ Visual Reference/ Source

Private Zenhub Video

severinbeauvais commented 3 weeks ago

I looked into this and I think it's a valid bug. The Review and Confirm step should not display the check mark unless everything on that page is completed (including the Certify checkbox).

Hint: see how the stepper component knows whether to display the check mark.