search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Edit UI: logic around changing business type and needing a new NR is broken #24084

Open severinbeauvais opened 2 weeks ago

severinbeauvais commented 2 weeks ago

Steps to reproduce:

  1. open a named BC business
  2. start an alteration
  3. change business type from BC to ULC
  4. observe the red warning text:
image.png
  1. click checkbox
  2. observe that the Done button is disabled:
image.png
  1. observe that you are stuck
  2. however, if you have an alteration NR, enter it now, then click Done:
image.png
  1. observe that the Business Type change has not been accepted:
image.png
  1. click Cancel for the business type change (since it's already been accepted)
  2. observe that you can now proceed to the Review and Certify page (and file and pay, etc):
image.png

The above also fails when source type is BEN or target type is CC.

Note also that if the source business is numbered, there is no prompt or indication that the name will be changed (eg, from "1234567 B.C. LTD." to "1234567 B.C. UNLIMITED LIABILITY COMPANY").

severinbeauvais commented 6 days ago

It has been decided that alteration of business type will be part of the Directed Launch. Therefore, this ticket can now be worked on.

ArwenQin commented 6 days ago

@Mihai-QuickSilverDev @OlgaPotiagalova cc: @severinbeauvais

Currently, if the user wants to alter a Named BC to a Numbered ULC, they need to file 2 separate changes: First step, change name - change the Named BC to a numbered BC, file it; Second step, change legal type - change the numbered BC to a numbered ULC, and file it.

The reason is the current functionality only allows change from a named to a numbered by appending "B.C. Ltd." / or "UNLIMITED LIABILITY COMPANY", just same with the current legal type. It's not linking to the type change function. Type changes, like a limited company to an ULC, doesn’t automatically trigger the name change to update.

Do you think we should update the logic, to allow change a Named BC to a Numbered ULC in one single alteration filing? Or is it ok for now?

OlgaPotiagalova commented 6 days ago

@ArwenQin for now let's just fix the problem in the ticket description.

For the scenario you described in the comment, please create a separate ticket and link to the Go-live clean-up epic. Thank you.

ArwenQin commented 5 days ago

Created #24300 https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/24300

severinbeauvais commented 5 days ago

Duplicate ticket: #24299.