search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Namex API - missing conversion request type (BEN to CC) #24193

Open eve-git opened 3 weeks ago

eve-git commented 3 weeks ago

Work on this ticket at the same time as #23382.

There are 8 name request types for conversion (CNV):

  1. BECR - Benefit Company → BC Limited
  2. BECV - BC Limited → Benefit Company
  3. CCV - BC Limited → Community Contribution Company
  4. ~CSSO - Society - Conversion of a Special Act~ not in scope for this ticket
  5. UC - BC Limited → Unlimited Liability Company
  6. ULCB - Unlimited Liability Company → BC Limited
  7. ULBE - Unlimited Liability Company → Benefit Company

One is missed:

  1. BECC - Benefit Company → Community Contribution Company (new request type that introduced in this ticket)

~Corresponding changes may be required in Name Request and/or Name Examination.~ See also Namerequest UI ticket: #24190 See also Name Examination UI ticket: #24255

severinbeauvais commented 3 weeks ago

~I set this as high priority because it's blocking continuation in alteration testing (ticket #23380).~ see updated comments below

severinbeauvais commented 2 weeks ago

It has been decided that alteration of business type will be part of the Directed Launch. Therefore, this ticket can now be worked on.

severinbeauvais commented 2 weeks ago

This is high priority for Directed Launch.

severinbeauvais commented 2 weeks ago

PO has decided that this is low priority because we haven't seen any of these in Prod in the last few years. We can work on this later.

ozamani9gh commented 2 weeks ago

Omid to discuss with @severinbeauvais about who should complete work.

severinbeauvais commented 2 weeks ago

I believe there is just 1 conversion NR type missing (BEN to CC). I expect the code has a table with the values, so it should be one line of code to update this.

What I can't tell you is if this is absolutely required for Directed Launch. Please ask Olga.

OlgaPotiagalova commented 1 week ago

@ozamani9gh, @severinbeauvais this is not required for directed launch. Such alteration types did not occur so far, so it is low probability of happening.

OlgaPotiagalova commented 1 week ago

We will review it before the MVP release

severinbeauvais commented 5 days ago

Test Notes

I recommend testing this ticket along with #23382.

Please verify that creating all types of conversion NRs functions correctly.

Specifically:

  1. BECV - BC Limited → Benefit Company
  2. CCV - BC Limited → Community Contribution Company
  3. UC - BC Limited → Unlimited Liability Company
  4. BECR - Benefit Company → BC Limited
  5. BECC - Benefit Company → Community Contribution Company
  6. ULCB - Unlimited Liability Company → BC Limited
  7. ULBE - Unlimited Liability Company → Benefit Company

and the continued-in equivalents:

  1. BECV - continued-in BC Limited → continued-in Benefit Company
  2. CCV - continued-in BC Limited → continued-in Community Contribution Company
  3. UC - continued-in BC Limited → continued-in Unlimited Liability Company
  4. BECR - continued-in Benefit Company → continued-in BC Limited
  5. BECC - continued-in Benefit Company → continued-in Community Contribution Company
  6. ULCB - continued-in Unlimited Liability Company → continued-in BC Limited
  7. ULBE - continued-in Unlimited Liability Company → continued-in Benefit Company