SBC Staff cannot access full Re-Issue Transport Permit Options

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 59 forks source link

SBC Staff cannot access full Re-Issue Transport Permit Options #24243

Open arlentees opened 2 weeks ago

arlentees commented 2 weeks ago

SBC Staff should be able to amend, extend create new, cancel any transport permit, with the limitation that they can only extend a permit once.

Currently, SBC Staff can only create new transport permits in TEST - this is with the FF being TRUE for all segments:

SBC Staff - missing options 1 - Screenshot 2024-11-05 131512.png

cameron-eyds commented 2 weeks ago

Hey sir, this is the same scenario that a qualified supplier would see for a Permit they did not issue. In this case, the api is returning a property informing the UI: changePermit: false.

This is probably due to the scenario that SBC didn't issue the original TP, should this be the case? Or should SBC Staff be treated in the same way as a Registries Staff when it comes to taking any action on any permit etc?

If they should be treated just like Registries Staff with regards to amending, cancelling, extending and creating new, than it is a simple thing to adjust you bet, is that what we want to do?

arlentees commented 2 weeks ago

I'm just double the checking the notes but I believe that yes, SBC Staff should be able to have similar access as Registries Staff with the only difference being that SBC Staff can only extend a permit once, where Registries Staff do not have a limit.

cameron-eyds commented 2 weeks ago

@arlentees Copy that, sounds good. I've adjusted the condition to give SBC the same permissions, will go in with the next commit!

chdivyareddy commented 2 days ago

Hey @doug-lovett , Can you please update the API changePermit property to True for SBC staff as this is a new requirement to allow them to file transport permits, only condition is that they can only extend the transport permit once. Please let me know if a new ticket is required, thanks!

doug-lovett commented 2 days ago

@chdivyareddy this ticket is for UI work. If no corresponding API ticket exists then please create one with the same description. To clarify SBC staff can only extend the currently active permit once. You can assign the ticket to me and put it in the In Progress pipeline.

chdivyareddy commented 2 days ago

@doug-lovett thank you! Created #24501 for the API and assigned it to you:)

chdivyareddy commented 1 day ago

Verified in TEST!

MHR 108685: When user tries to extend transport permit more than once.