search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Name Examination UI: need to update NR request types #24255

Open severinbeauvais opened 2 weeks ago

severinbeauvais commented 2 weeks ago

Namex API has the following structure to map NR request types to display strings and actions: https://github.com/bcgov/namex/blob/main/api/namex/services/lookup/name_request_filing_actions.py#L48 (related Namex ticket: #24193)

Name Examination UI has a similar table that needs to be updated. This table is used to populate the NR request type selection menu:

image.png

The following conversion types need to exist in the table. Please verify and add any missing entries (BECC is new):

  1. BECV - BC Limited -> Benefit Company
  2. CCV - BC Limited -> Community Contribution Company
  3. UC - BC Limited -> Unlimited Liability Company
  4. BECR - Benefit Company -> BC Limited
  5. BECC - Benefit Company -> Community Contribution Company
  6. ULCB - Unlimited Liability Company -> BC Limited
  7. ULBE - Unlimited Liability Company -> Benefit Company
severinbeauvais commented 2 weeks ago

@ozamani9gh Does your team have bandwidth for this ticket before Directed Launch (Nov 27)?

@OlgaPotiagalova FYI.

severinbeauvais commented 2 weeks ago

This is high priority for Directed Launch.

vikas-gov commented 1 week ago

Reviewed with Omid, being checked if this can be prioritized/completed before code freeze (~Nov20) for directed launch

stevenc987 commented 1 week ago

I checked others were implemented except for BECC. I implemented BECC and got the result.

New entry data after implemented

image.png
severinbeauvais commented 1 week ago

Looks good to me. Thanks, Steven!

stevenc987 commented 6 days ago

Note: This was moved to TEST. It needs to be tested and moved up with NRO decommissioning

severinbeauvais commented 5 days ago

@stevenc987 Please tag this to an appropriate Names epic and release. (I am removing it from Olga's sprint.) Thanks!

ozamani9gh commented 5 days ago

@gunanagar feel free to reach out to Severin for assistance. Business-edit-UI

severinbeauvais commented 5 days ago

Test Notes

To verify:

  1. in Namerequest UI, create a NR that is not for altering a business type
  2. in Name Examination UI, edit the NR and change it to a "Ben to CCC" conversion NR; also enter the corp num of a BEN business
  3. open the BEN business
  4. ensure it already has 3 or more directors
  5. click "View and Change Company Information"
  6. in Busines Edit UI, change Company Name using NR created above; it should change the name and change the business type
  7. in Busines Edit UI, file the alteration