bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Name-Examination UI - error occurred when selecting conflict or conflict selection has values #24298

Open eve-git opened 2 weeks ago

eve-git commented 2 weeks ago

When the conflict selection option is not empty after loading or when selecting a conflict in the conflict box, warnings and errors appear in the Dev Tools console. This results in no response for actions like page navigation (e.g., clicking search) or editing.

The current version in PROD (1.2.30) works correctly, but the versions in TEST (1.2.32) and DEV (1.2.33) have this issue. I believe this might be a known issue, so please close the ticket if it’s a duplicate.

It might be connected to this pull request: https://github.com/bcgov/name-examination/pull/1536, which is the version 1.2.32.

image.png image.png
eve-git commented 2 weeks ago

If there exist a conflict name, which has been consumed, name-examination needs to show the following corp information from COLIN (Entity as well I assume):

BC CORP: {'identifier': corp_num,
          'incorporated': incorp_date_str,
          'directors': incorp_directors_list,
          'registered office delivery address': incorp_registered_addr_list,
          'records office delivery address': incorp_records_addr_list,
          'jurisdiction': 'BC',
          'nature of business': incorp_nob
}

XPRO CORP: {'identifier': corp_num,
            'incorporated': incorp_date_str,
            'directors': incorp_directors_list,
            'attorney names': incorp_attorneys_list,
            'head office': incorp_ho_addr_list,
            'jurisdiction': incorp_jurisdiction,
            'nature of business': incorp_nob
}
eve-git commented 2 weeks ago

for example in UI, when clicking highlighted line, the detail corp info should show up.

image.png

the corresponding data should be returned from getCorporation(corp_num):

{
    "directors": "Not Available",
    "incorp #": "XS1000661",
    "incorporated": "2016-12-08",
    "jurisdiction": "BC",
    "nature of business": "Not Available",
    "records office delivery address": "Not Available",
    "registered office delivery address": [
        "VICTORIA",
        "BC",
        "CA",
        "V8Y 3B6"
    ]
}

For a BC corp, the following field need to be returned:

BC CORP: {'identifier': corp_num,
          'incorporated': incorp_date_str,
          'directors': incorp_directors_list,
          'registered office delivery address': incorp_registered_addr_list,
          'records office delivery address': incorp_records_addr_list,
          'jurisdiction': 'BC',
          'nature of business': incorp_nob
}
eve-git commented 2 weeks ago

Test: There are three sources of conflict:

  1. Approved/Conditionally Approved Names in Name Request
  2. Corporations from BCROS – for example, benefit companies
  3. Corporations from COLIN – for example, extra-provincial corporations (CORPs)

Please find some examples to test. Currently, corporation information isn’t retrieved correctly, so no information will display (see screenshot above) until #24319 is completed. However, there should be no warnings or errors, and other functions should operate without issues.

For Name Request, the information should display as follows:

image.png
gunanagar commented 2 days ago

Tested, no error found in console.

Screen Shot 2024-11-25 at 12.55.39 PM.png