Email Delivery - Missing PDF Document_Voluntary Dissolutions

[ArwenQin]

Do a Voluntary Dissolution, the Voluntary Dissolution Application PDF is consistently missing in the email, despite the email says it's attached:

The Certificate of Dissolution is occasionally missing, less likely — out of five tests, it was missing once:

[severinbeauvais]

For both businesses above, the Voluntary Dissolution ledger item shows 3 outputs:

• Certificate of Dissolution
• Voluntary Dissolution (the application)
• Receipt

For both businesses above, all 3 outputs can be downloaded successfully (though one sometimes fails when using the Download All button).

Therefore, this is intermittent, even from the ledger item link.

cc: @vysakh-menon-aot

Refs: https://test.business.bcregistry.gov.bc.ca/BC1147549 https://test.business.bcregistry.gov.bc.ca/BC1147557

[eason-pan-bc]

Conducted some preliminary analysis by continuously running requests for getting the documents for Voluntary Dissolution in Test and localhost. APIs used: {{url}}/api/v2/businesses/:identifier/filings/:filing_id/documents/certificateOfDissolution {{url}}/api/v2/businesses/:identifier/filings/:filing_id/documents/dissolution {{url}}/api/v2/businesses/:identifier/filings/:filing_id/documents/receipt identifier: BC1147549 filing_id: 395618

Results https://docs.google.com/spreadsheets/d/1oH9e-p7voY4puV_GzzLb6X0iTGBwC8DUzcz_lfjm14c/edit?usp=sharing

Since it's intermittent, and getting the documents takes pretty long response time. I suspect there might be some cutoff time setting (maybe) or there are some BE logic in the emailer has some bug, will dig into Entity Emailer next week, also a potential consideration is Notify API.

[eason-pan-bc]

@severinbeauvais @vysakh-menon-aot Currently, the Voluntary Dissolution Application.pdf only be attached to an email when the Filing.Status is PAID, not for COMPLETED. Code reference in Emailer: https://github.com/bcgov/lear/blob/main/queue_services/entity-emailer/src/entity_emailer/email_processors/dissolution_notification.py#L54C5-L68C34 And since the process is from filer then go to emailer, that might be why it's always missing in the voluntary dissolution email attachment, since it emails out when the filing is completed.

Question: do we want to change this logic to make the Voluntary Dissolution Application.pdf gets attached to both status (PAID and COMPLETED) ?

---

The root causes of intermittently missing PDFs is still under investigation, potential cause might be long running time and got kicked out before all PDFs are generated. (this is an assumption at this moment).

[vysakh-menon-aot]

Question: do we want to change this logic to make the Voluntary Dissolution Application.pdf gets attached to both status (PAID and COMPLETED) ?

No. It's the requirement. entity-emailer will receive the message to process PAID status emails from business-pay (https://github.com/bcgov/lear/blob/main/queue_services/business-pay/src/business_pay/resources/pay_filer.py#L155)

[eason-pan-bc]

Question: do we want to change this logic to make the Voluntary Dissolution Application.pdf gets attached to both status (PAID and COMPLETED) ?

No. It's the requirement. entity-emailer will receive the message to process PAID status emails from business-pay (https://github.com/bcgov/lear/blob/main/queue_services/business-pay/src/business_pay/resources/pay_filer.py#L155)

thank you for clarification. found some other issues, will dig into the other directions.

[eason-pan-bc]

Notes for fixing consistently not getting Voluntary Dissolution Application.pdf attachment in Emails

After the PR https://github.com/bcgov/lear/pull/3073 merged. Tested in Dev, in MailHog, the 2 emails and 3 attachments are both there

[eason-pan-bc]

The root cause for intermittent missing PDF file(s) is the same as https://github.com/bcgov/entity/issues/24321#issuecomment-2475147685

And the issue has been addressed in https://github.com/bcgov/entity/issues/24321#issuecomment-2479842899

[vishnup0422]

Dev Env:

Filing a Dissolution for a BEN BC0883763 FilingId: 152553

Voluntary Dissolution

Certificate of Dissolution

Receipt

Test Env:

BEN: BC1152926 filing_id=395953

Voluntary Dissolution

Certificate of Dissolution

Receipt