bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

QA Issue Entity Dashboard - Notification header link error #24331

Closed gunanagar closed 1 week ago

gunanagar commented 3 weeks ago

Describe the bug in current situation QA Issue Entity Dashboard - Notification header link error

Link bug to the User Story

Impact of this bug Describe the impact, i.e. what the impact is, and number of users impacted.

Chance of Occurring (high/medium/low/very low) High

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?

Steps to Reproduce Steps to reproduce the behavior:

  1. Go to new dashboard for any account
  2. check the header -

In March 2025, B.C. company filings and search will move to the BC Registry application. Learn more at bcreg.ca/corporations.

Actual/ observed behavior/ results In March 2025, B.C. company filings and search will move to the BC Registry application. Learn more at bcreg.ca/corporations.

i

Expected behavior

t should be like - In March 2025, B.C. company filings and search will move to the BC Registry application. Learn more at bcreg.ca/corporations.

Refer to https://github.com/bcgov/business-filings-ui/pull/702 for the style of the banner.

Screenshots/ Visual Reference/ Source

New Dashboard

image.png

<img width="1371" src="https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBNStwQnc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--ccdcc4284be69e2b914af6d526bf2635eea532f0/image.png" alt="image.png" />

[Uploading... image.png]

Old Dashboard

image.png
mstanton1 commented 3 weeks ago

Thanks for flagging this one @gunanagar . I believe these messages are handled through our feature flags.

@pwei1018 can you look at the bug above and let me know if it's to do with the feature flags? If so, is this something your team might be able to add into your next sprint?

pwei1018 commented 3 weeks ago

@mstanton1 I can't see the screenshot. Is it banner message?

pwei1018 commented 3 weeks ago

image

The issue is with the code: the banner component is unable to render the HTML content as expected. You can let your developer to look at it.

mstanton1 commented 2 weeks ago

Thanks for the info @pwei1018

patrickpeinanw commented 2 weeks ago

@mstanton1 @BrandonSharratt Just FYI, the styling for the banner has been updated in the current Entities dashboard. When working on this ticket, we can update the styling to reflect the new changes in https://github.com/bcgov/business-filings-ui/pull/702.

mstanton1 commented 2 weeks ago

Thank you @patrickpeinanw !

gunanagar commented 1 week ago

Tested in new dashboard, issue have been fixed

Screen Shot 2024-11-21 at 10.59.47 AM.png