search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Filings UI / Business Dashboard UI: invalid redirect after selection Change of Directors filing #24457

Closed severinbeauvais closed 5 days ago

severinbeauvais commented 5 days ago
  1. login to Dev as BCREG0028
  2. go to https://business-dashboard-dev.web.app/BC0883757/
  3. click Change button beside Current Directors

Expected Result: you are redirected to local COD filing in Filings UI.

Actual Result: There are least 2 redirections and you end up on this page: https://business-dashboard-dev.web.app/BC0871427

Impacts:

However, this is only if the "use new business dashboard" FF is True (which is only BCREG0028 and another user atm, in Dev and Test only).

This may be related to 24423.

severinbeauvais commented 5 days ago

@mstanton1 @hfekete FYI.

mstanton1 commented 5 days ago

@severinbeauvais thanks for flagging this. I've pinned as high priority for my team to groom and tackle.

severinbeauvais commented 5 days ago

Here is what's happening:

  1. Business Dashboard UI redirects to Filings UI to perform COD filing:
  2. Filings UI sees FF as True and redirects back to Business Dashboard UI (this is incorrect -- should not redirect for local filings):
  3. Business Dashboard UI redirects for login:
  4. Business Dashboard UI mysteriously tries to load data for "undefined" business, and then a different business (hard-coded id?):
image.png
hfekete commented 5 days ago

Yes, I believe that updating redirect in Filings UI to check if it is filing that needs redirection would solve the issue.

What you wrote is true, and yes, we put hardcoded id in dev/test (this was to speed up testing and development I believe). This hardcoded ID can be removed now that we can test with redirects and all .

severinbeauvais commented 5 days ago

Thanks, Hrvoje. The new dashboard should display an error if it cannot load all the business data (ie, all the 404 above).

I fixed the redirection issue, and this problem has gone away. Please ensure that Business Dashboard UI doesn't do anything weird when the URL is, say, https://business-dashboard-dev.web.app/BC0883757/standalone-directors?filingId=0&accountid=3.

severinbeauvais commented 5 days ago

Hrvoje, if you don't need this ticket, please close it. Thanks!

hfekete commented 5 days ago

Thank you Severin! We do not need this the ticket, closing it.