bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Only owner is allowed to change the account Name #2497

Closed ghost closed 4 years ago

ghost commented 4 years ago

Describe the bug in current/ actual behaviour/ situation

Scenario 1 ADMIN LOGIN GIVEN I am logged in as an admin using BCSC WHEN I edit Account Name in Account info THEN I am able to save the changed account name which is a bug

OR

Scenario 2 MEMBER LOGIN GIVEN I am logged in as an admin using BCSC WHEN I edit Account Name in Account info THEN I am able to edit account name but cannot save which is a bug

Pre Conditions

Steps to Reproduce Admin Login

  1. Login as admin using BCSC
  2. Navigate to the Account Info screen, by selecting option from the account menu
  3. Edit the Account Name and click on Save button

Member Login

  1. Login as admin using BCSC
  2. Navigate to the Account Info screen, by selecting option from the account menu
  3. Edit the Account Name and click on Save button

Actual Behaviour Admin Login - As an admin, I can edit and save the Account Name Member Login- As an member, I can edit the account name but can't save it

Expected behaviour Admin's or Member's are not allowed to edit or save the Account Name. only owners are allowed to edit or save the Account Name

Screenshots/ Visual Reference

Admin Login 1. Admin can also change the Account Name. However, in the ticket description above- only owners are allowed to change the Account Name.

Visual Reference Loged in as Admin Screen Shot 2020-01-24 at 5.17.21 PM.png

Account Name changed Screen Shot 2020-01-24 at 5.16.17 PM.png

2. As a Member If I change the Account Name, Proper error handling should be displayed or this option should be made disabled

Logged in as a Member Screen Shot 2020-01-24 at 5.19.40 PM.png

Change Account Name Screen Shot 2020-01-24 at 5.20.25 PM.png

saravankumarpa commented 4 years ago

@nitin-freshworks plz test this

ghost commented 4 years ago

Works fine in dev env. Moving it to done.