search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Incorrect message when wrong datatype in passcode #2736

Closed Milan-Freshworks closed 4 years ago

Milan-Freshworks commented 4 years ago

Describe the bug in current/ situation The error message displayed is not descriptive when wrong datatype is entered in passcode

Impact of this bug Describe the impact, i.e. what the impact is, and number of users impacted.

Pre Conditions (which Env, any pre-requesites or assumptions to execute steps?

Steps to Reproduce Steps to reproduce the behavior:

  1. Login
  2. Click on 'Add Business'
  3. Add Incorporation number and in passcode add dummy data 'Abc*&(978'
  4. Click on 'Add Business' button

Actual/ observed behavior/ results 'Passcode Already Claimed This passcode has already been claimed. If you have questions, please call 1-877-526-1526' error appears

Expected behavior

Screenshots/ Visual Reference/ Source If applicable, add screenshots to help explain your problem. You an use screengrab. Screen Shot 2020-02-19 at 11.07.18 AM.png Screen Shot 2020-02-19 at 11.07.13 AM.png

WaldemarSchneider86 commented 4 years ago

@jeznorth - change the wording? - what error message should be shown?

jeznorth commented 4 years ago

Can you please clarify what you are expecting here? If the data entered here is in fact an invalid format and/or 'datatype' then yes, we should be displaying the appropriate messaging (I.E. 'Invalid Passcode' and associated message).

While there are newer designs ready to be implemented for these notifications (they have not yet been captured), this looks like it could be an error introduced as part of #2502 - I'm fairly certain there used to be an 'Invalid Passcode' notification here. @nitheesh-aot might be able to respond better as I believe he was working on this ticket last sprint.

nitheesh-aot commented 4 years ago

The code checks for the password already claimed flag first, if thats true, it will send out the already claimed error. we have to change the code to check for the format and validation first and then to the password claimed flag. This will be an easy fix, but if we are changing the notification contents, then shall we do this along with that once that approved?

thoughts @jeznorth @WaldemarSchneider86 @Milan-Freshworks ?

WaldemarSchneider86 commented 4 years ago

Proposed Text, agreed w. the team just now:

Business already claimed.

WaldemarSchneider86 commented 4 years ago

Not valid anymore - discussed in Bug-Triage w. Andrew, nitin and Amit