bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Create UI: need to save latest NR data in filing #3906

Open severinbeauvais opened 4 years ago

severinbeauvais commented 4 years ago

Description:

Currently, when the Create UI app starts up, it fetches the (latest) data for the NR. This NR object needs to be saved in the filing that is saved to the API.

This will allow a future ticket (TBD) to compare the latest vs saved NR to see if it has changed (and to update any global state data accordingly).

This will also store the NR that was used for the incorporation application (ie, auditing).

Acceptance for a Task:

severinbeauvais commented 4 years ago

I've assigned this to Kaine as we may need (or want) this for MVP.

severinbeauvais commented 4 years ago

@thorwolpert Any thoughts on this?

Kaineatthelab commented 4 years ago

we want to do this as long as it was an agreed strategy on how to do it:)

severinbeauvais commented 4 years ago

IIRC, we decided to check if the NR is valid:

  1. when the Create UI loads the draft IA (already implemented)
  2. when the Create UI displays the review page (optional?)
  3. when the Create UI processes the user's File & Pay button click
  4. when the Legal API receives the IA to file (ie, validation)

@forgeuxGH5 What should error handling do / look like?

4 potentially add 10-15 grace period after user selects file & pay to deal with pending backend stuff.

4 is to protect ourselves from third parties who are submitting IA's (for example Ecorp, etc.)