search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Create UI: some changes don't trigger "unsaved changes" dialog #4802

Open severinbeauvais opened 4 years ago

severinbeauvais commented 4 years ago

Describe the bug in current situation In the Create UI code, any time the user modifies a store value (eg, Folio Number) and then tries to exit without saving, the framework should prompt with "You have unsaved changes. Are you sure you want to leave?"

However, some store values are missing some code to enable this. See https://github.com/bcgov/bcrs-business-create-ui/blob/master/src/store/mutations/mutations-model.ts.

The developer will have to determine which store values need this code. (Changes made by the app itself don't need this.)

Link bug to the User Story N/A

Impact of this bug Some changes the user has made won't trigger the "unsaved changes" dialog.

Chance of Occurring (high/medium/low/very low) See description.

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps? See description.

Steps to Reproduce See description.

Actual/ observed behavior/ results See description.

Expected behavior See description.

Screenshots/ Visual Reference/ Source N/A

severinbeauvais commented 3 years ago

I estimate 1/2 day for a developer to identify the changes that a user could make that should trigger this check, and update the code accordingly. (There is already a framework/architecture in place to do this; it's just a bit out of date.)

severinbeauvais commented 3 years ago

Ticket #6209 describes a related situation (File and Pay should be enabled when changes have been made).

I think THIS ticket and #6209 could/should be worked on together.