bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Improvements to the deploy scripts #4992

Open severinbeauvais opened 3 years ago

severinbeauvais commented 3 years ago

Description:

  1. Sometimes the deploy scripts output display "FAILURE" even when they succeed. (This may happen when a new deployment is not triggered because the image is already deployed.) This should be fixed. Eg,

    [Pipeline] }
    [Pipeline] // script
    [Pipeline] }
    [Pipeline] // stage
    [Pipeline] }
    [Pipeline] // node
    [Pipeline] End of Pipeline
    Finished: FAILURE
  2. The Prod deploy scripts should prompt before running, to prevent inadvertently running it (which sometimes happens because all pipelines look similar in OpenShift).

Acceptance for a Task:

severinbeauvais commented 3 years ago

@kialj876 Do you have anything to add?

@cameron-freshworks FYI!

severinbeauvais commented 2 years ago

@pwei1018 I think this has been pre-empted by the new Github Actions. Do you concur? If so then this ticket can be closed.