search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

UI Design - Validation for NR in the name request modals #5204

Open janisrogers opened 4 years ago

janisrogers commented 4 years ago

Determine the validation for entry of the NR number in the modals. This should be the same for all places where the modals appear (in Name Request, Correction filing, Business Dashboard, alteration filing, change of name filing, etc.

Normalize all inputs to display as NR xxxxxxx (eg NR 1234567) in the NR number field

Allow the following: number only "1234567" NR with no space before number "NR1234567" nr in lowercase "nr1234567","nr 1234567" NR with single or multiple spaces before number "NR 1234567"," nr 1234567", "NR 1234567" number only with leading or trailing spaces " 1234567","1234567 " Preceding and Trailing spaces with or without NR should be allowed but normalized ~We should also normalize if there is a space in the middle. 'NR 12 34567'~

janisrogers commented 4 years ago

@forgeuxGH5 Do we need wireframes for this? It seems pretty straightforward.

severinbeauvais commented 3 years ago

We should also normalize if there is a space in the middle. 'NR 12 34567'

I think this one should be treated as an error. (We could implement this but I think the user really shouldn't be entering a NR in this format.) This example looks to me like a data entry error (not a normalization exercise).

tlebedovich commented 3 years ago

@janisrogers - should this go into New Issues or Bugs?

janisrogers commented 3 years ago

@tlebedovich The list of specs is done, so I guess it should go in Review?

tlebedovich commented 3 years ago

Yes I think Kaine was saying to park any one-off design tickets in Review and tag a PO to get a dev ticket made for it to be linked to, then design ticket can be moved to Done was its linked.

On May 26, 2021, at 12:45 PM, janisrogers @.***> wrote:

 @tlebedovich The list of specs is done, so I guess it should go in Review?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

janisrogers commented 3 years ago

@Kaineatthelab @lmcclung This is ready, but the attached ticket is in analysis. Does a dev ticket need to be created?

Kaineatthelab commented 3 years ago

@janisrogers looks like the ticket is already blocking this one:)

janisrogers commented 3 years ago

@Kaineatthelab Yes, but it is in analysis, and I think the analysis is done. Should it be in backlog?

Kaineatthelab commented 3 years ago

yes move it to the backlog pls

jdyck-fw commented 3 years ago

@Kaineatthelab - I believe this one may belong in the Assets sprint

severinbeauvais commented 2 years ago

Are the requirements (in this ticket's description) finalized? And so the blocked UI tickets can now be implemented?

janisrogers commented 2 years ago

@severinbeauvais The requirements are finalized.