Back end Stuff

[Kaineatthelab]

CLOSED and remaining move to https://app.zenhub.com/workspaces/entity-5bf2f2164b5806bc2bf60531/issues/bcgov/entity/6059

To do:

• [ ] Verify that the correct actions are provided according to all NR states described in https://docs.google.com/spreadsheets/d/1SVmnnl-mpROjYICsD6nvHoFVrcAxaOHewdsDJXE1S74/edit?usp=sharing
• [ ] ~Always have "Cancel and Refund" (REFUND) or "Cancel" (CANCEL) buttons at the bottom of the list.~ already handled by UI, lowest priority
• [ ] ~Create new state for "Approved, Used For XXX".~ this is existing Consumed state (aka Completed?)
• [ ] ~Create a new state for "Expired".~ Not in scope for this ticket. See #5669 instead.
• [ ] ~Create a new state for "Refunded".~ This is future. For now we don't know when the refund is complete.
• [ ] ~Create a new state for "Cancelled, Refund Requested".~ REFUND_REQUESTED is implemened in #5708.
• [ ] ~Generate Results Letter PDF generation and an API to retrieve it.~ blocked by PO decision and/or design
  • create PDF template
  • write code to populate the template with data
  • create new API call (/payments/<id>/result ???) (maybe not "payments"?) - Pushed after MVP
• [ ] ~do not capitalize applicant name in response~ Looks like this works already (for some NRs).
• [ ] ~do not capitalize address fields in response~ Looks like this works already (for some NRs).
• [ ] ensure INCORPORATE action is only provided for BCOMP (BC) NRs
• [x] do not provide REAPPLY action for MVP (may be re-enabled later)

Note for @vysakh-menon-aot regarding "Extend Expiry ($30)" button & "Expiry Extensions Remaining" label from @forgeuxGH5:

The first appearance of the "Extend Expiry" button and the Expiry Extensions Remaining label occur at 12:01 am on the fifth day prior to the expiry of the approved (or conditionally approved) Name Request.

Upon successful payment of the extension: 1) the expiration date is extended to 12:01 on the 56th day after the original expiration date, 2) the Expiry Extensions Remaining counter is decreased by 1. After an extension is applied, the Expiry Extensions Remaining label is always displayed.

[severinbeauvais]

@vysakh-menon-aot

For NR 1666961 (john.a.m.lane@gov.bc.ca), both CANCEL and REQUEST_REFUND actions are provided -- only one or the other should display.

Per Scott:

If Request Status = "Draft" then the button is "Cancel and Refund". If Request Status = "Approved" or "Conditional" then the button is "Cancel Name Request". For all other Request Status values the button is not displayed.

[forgeuxGH5]

Also we still need to confirm the expiry extension times. @severinbeauvais do you remember the rules from when we did the NR in the Incorporation Application flow? Can we reuse those here? This is the UI we built for the IA (this is in on the Business Dashboard (Edit UI right?):

[severinbeauvais]

@forgeuxGH5 Yes, I used the same method to determine when the NR expires. In a nutshell, if the date is today, it's expired.

[severinbeauvais]

PS I think your screenshot is from the Todo List on the entity dashboard -- Filings UI.

[forgeuxGH5]

Yes! Filings UI - thanks.

[vysakh-menon-aot]

@severinbeauvais API won't return Receipt action button if payment is failed (regardless of the nr status)

[severinbeauvais]

@severinbeauvais API won't return Receipt action button if payment is failed (regardless of the nr status)

OK. Does it currently display correctly in other cases?

[vysakh-menon-aot]

@severinbeauvais API won't return Receipt action button if payment is failed (regardless of the nr status)

OK. Does it currently display correctly in other cases?

Merged PR now. Triggered a build.

[severinbeauvais]

@vysakh-menon-aot I just learned a new rule for actions: "The INCORPORATE action should only be provided for Benefit Company (BC) NRs."

That said, the UI has a check for this as well.

[tlebedovich]

@vysakh-menon-aot @severinbeauvais It would be great to be able to test to make sure all buttons are showing up according Sienna's spreadsheet by testing each type of NR request. Will this be happening in QA? For example, I just looked up an In Progress number and I believe it was supposed to show a receipt button but did not. Just wanted to make sure this is all being confirmed before launch.

[severinbeauvais]

The developers working on this ticket should be testing this themselves.

Also it would be great if this testing was a team effort.

@jdyck-fw Can you please this up at Standup (ie, how we are doing team testing)? Thx!

[severinbeauvais]

Here's a cancelled NR (in Test, NR 3444516, phone 2503568724):

According to the spreadsheet, it should display only the Receipts button (if there is a receipt -- in this case the NR did not have a receipt when it was approved)... so this is OK, but we need another test for a cancelled NR with a receipt(s).

@severinbeauvais there is no receipt because it was created in NRO right?

[tlebedovich]

@severinbeauvais @vysakh-menon-aot Should it say "XPRO" Limited Company? That feels like an internal label, not a client-facing label - can someone review the company labels that are going to show up beside the NR number? (I wouldn't be the right person, but just wanted to note the issue). Let me know if you want this as a new ticket. c/c @janisrogers @forgeuxGH5

[forgeuxGH5]

It should display Extraprovincial Limited Company - we definitely need to do as Tracey suggests - check the values we're getting for these.

[severinbeauvais]

Rejected (with receipts) and also XPRO... looks good!

[severinbeauvais]

It should display Extraprovincial Limited Company - we definitely need to do as Tracey suggests - check the values we're getting for these.

OK. I will create a new ticket.

[severinbeauvais]

@forgeuxGH5 ^^^ actually, the list of displayed entity types was approved by Linda. Do you still want it changed? And any others from this list...?

  /** Returns entity type text for the the specified code. */
  entityTypeCdToText (cd: EntityType): string {
    switch (cd) {
      // BC Entity Types:
      case EntityType.FR: return 'BC Sole Proprietorship'
      case EntityType.DBA: return 'BC "Doing Business As" name (DBA)'
      case EntityType.CR: return 'BC Limited Company'
      case EntityType.UL: return 'BC Unlimited Liability Company'
      case EntityType.GP: return 'BC General Partnership'
      case EntityType.LP: return 'BC Limited Partnership'
      case EntityType.LL: return 'BC Limited Liability Partnership'
      case EntityType.CP: return 'BC Cooperative Association'
      case EntityType.BC: return 'BC Benefit Company'
      case EntityType.CC: return 'BC Community Contribution Company'
      case EntityType.SO: return 'BC Social Enterprise'
      case EntityType.PA: return 'BC Private Act'
      case EntityType.FI: return 'BC Credit Union'
      case EntityType.PAR: return 'BC Parish'

      // XPRO Entity Types:
      case EntityType.XCR: return 'XPRO Limited Company'
      case EntityType.XUL: return 'XPRO Unlimited Liability Company'
      case EntityType.RLC: return 'XPRO Limited Liability Company'
      case EntityType.XLP: return 'XPRO Limited Partnership'
      case EntityType.XLL: return 'XPRO Limited Liability Partnership'
      case EntityType.XCP: return 'XPRO Cooperative Association'
      case EntityType.XSO: return 'XPRO Social Enterprise'

      default: return cd
    }
  }

[tlebedovich]

Maybe it's a space issue @forgeuxGH5?

[severinbeauvais]

(There's lots of space on that line.)

[severinbeauvais]

New ticket for possible changes: https://app.zenhub.com/workspaces/entity-5bf2f2164b5806bc2bf60531/issues/bcgov/entity/5815

(Needs changes identified and approved by PO.)

[Kaineatthelab]

I added a P2 to it, not important right now:) @severinbeauvais

[severinbeauvais]

BUGS

(Bugs will be added to this list as they are found. Fixed bugs can be checked off.)

• [x] a cancelled NR with receipts fails to display the RECEIPT action (see NR 8748717 / severin.beauvais@gmail.com)
• [x] an expired NR incorrectly displays the REAPPLY action (see NR 8075449 / severin.beauvais@gmail.com)
• [x] an in-progress NR incorrectly displays REQUEST_REFUND action (see NR 1410820 / severin.beauvais@gmail.com)

Spreadsheet of sample NRs in Dev: https://docs.google.com/spreadsheets/d/1AFJmAWYug4SUCUNV_JBAmpfZhHL4LIrEUMFSHwBOcRU/edit#gid=0

[severinbeauvais]

a cancelled NR with receipts fails to display the RECEIPT action (see NR 8748717 / severin.beauvais@gmail.com)

There was (old) code that skipped all buttons for NRs in cancelled status. There seems to be no reason to have this check so I removed it. Looks fine now.

[severinbeauvais]

an in-progress NR incorrectly displays REQUEST_REFUND action (see NR 1410820 / severin.beauvais@gmail.com)

This not longer reproduces.

[severinbeauvais]

an expired NR incorrectly displays the REAPPLY action (see NR 8075449 / severin.beauvais@gmail.com)

I created new bug #5840 for this one.

[severinbeauvais]

@vysakh-menon-aot I just noticed this in this ticket's description

do not provide REAPPLY action for MVP (may be re-enabled later)

What is the status of this atm?

[vysakh-menon-aot]

@vysakh-menon-aot I just noticed this in this ticket's description

do not provide REAPPLY action for MVP (may be re-enabled later)

What is the status of this atm?

Seems like different from spreadsheet. As of now its enabled

[Kaineatthelab]

@severinbeauvais isn't the logic already in? I didn't put that in there so not sure where it came from

[severinbeauvais]

I don't remember the history of the REAPPLY button. Maybe @janisrogers or @forgeuxGH5 would know?

@Kaineatthelab Should we just test this (see #5840) and leave it enabled, or disable it for MVP?

[tlebedovich]

I don't know any helpful details, but do know that "Reapply" is the old name for the "Extend Expiry ($30)" button.

https://docs.google.com/spreadsheets/d/1SVmnnl-mpROjYICsD6nvHoFVrcAxaOHewdsDJXE1S74/edit#gid=0

[Kaineatthelab]

it is the same extend expiry, and should continue if possible

[severinbeauvais]

OK, then let's explicitly test the Extend Expiry functionality.

@vysakh-menon-aot , let's you and I look into this.

[severinbeauvais]

Since another REAPPLY ("Extend Expiry") bug (#5840) was deferred to post MVP, we decided to disable the REAPPLY action in the UI, as documented in this ticket's description, and a new ticket will be created to reinstate it post MVP.

[severinbeauvais]

@vysakh-menon-aot Found a bug: for the following NR, the Cancel and Refund button should not display. (The API is sending actions: ["RECEIPT", "REQUEST_REFUND"]).

[Kaineatthelab]

@severinbeauvais do you want 5840 to capture putting the extend back? It will be a P2 and need to be looked at next week:)

[severinbeauvais]

@severinbeauvais do you want 5840 to capture putting the extend back? It will be a P2 and need to be looked at next week:)

That's a good idea actually. @vysakh-menon-aot , FYI.

Kaine, you're going to need REAPPLY enabled in the BE and some solution for #5840 at the same time probably.

[Kaineatthelab]

:)

[lmcclung]

Perhaps it meant to say to remove the RESEND for MVP. We decided to remove that and have user screenprint the summary screen or staff RESEND in NRO as we didn't want to do throw away work to get mail working in old database or spend time building a download option.

[severinbeauvais]

@lmcclung You're probably right!

However, having removed the REAPPLY button isn't tragic (it was 1 line of code) as the expiry date functionality needs work anyway.

@vysakh-menon-aot Can you confirm that the RESEND button is currently never displayed (never sent by BE) ?