search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Deactivate basic account #5937

Closed lmullane closed 3 years ago

lmullane commented 3 years ago

Acceptance Criteria

Scenario 1: Deactivate account button

Scenario 2: Basic admin clicks deactivate button

Scenario 3: Basic admin clicks Deactivate Account button

Scenario 4: Basic admin clicks final Deactivate Account button

Scenario 5: Admin or staff with the account_creator group clicks cancel on deactivate view

Scenario 6: Admin or staff with the account_creator group clicks cancel on confirmation dialogue

Account Name Logic Change

For account with individual/personal name,

Scenario 7: Reuse the Legal Business Name after Account deactivation GIVEN that I have already deactivated an account that was using its Business Name as Account Name WHEN I want to re-use the same Business Name as my account name THEN I can use it, given that I am choosing a different branch Name

Scenario 8: Reuse the Individual personal Name after Account deactivation GIVEN that I have already deactivated an account that was using its Personal Name as Account Name WHEN I want to re-use the same Personal Name as my account name THEN system will not allow that and ask me to choose a unique account name

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Link to DoR for a US/ Feature https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoR%20-%20Relationships.md https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoR%20-%20Entity.md

Link to the DoD for a US/ Feature https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoD%20-%20Relationships.md https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoD%20-%20Entity.md

rkim13103 commented 3 years ago

All Red should be #D3272C

sumesh-aot commented 3 years ago

@jyoti3286 @mstanton1 Description says staff with account_creator group can also deactivate. Are we allowing staff deactivate? If so, I think it should be admin group as they deal with accounts. account_creator is used for creating director search accounts.

Also an AC needs to be added for staff.

mstanton1 commented 3 years ago

@sumesh-aot I think this should be allowed for staff but only those with the keycloak group account_creator (which is given to the BC Online Admin team). This is a team of four people who have traditionally handled finance related items.

The current PAD agreement states a client must notify us they wish to withdraw and can do so through web form or in writing. If something came in writing we need a single spot to store it so given the process having one team versed in finance makes sense.

@jyoti3286 there are options for how we implement. My thought is the simplest solution is to implement a PAD cancellation form (BA task) and then that could be submitted to BCOL Admin and stored through their current filing system. They could raise tickets for the few scenarios they receive and have the deactivation done on the back-end. A longer term, higher effort approach, could be to provide those in the account_creator group with the ability to upload a PAD cancellation form and then complete the deactivation within the system. Can you provide guidance on what should be done at this time?

image.png

jyoti3286 commented 3 years ago

@mstanton1 @sumesh-aot - As per the PAD agreement screenshot, I think we have to provide the ability for staff to deactivate. At this point, it does make sense to give the account creator group the ability to deactivate from a System standpoint. To summarize, this is how I am thinking:

Business Process

Having the Cancellation form also makes sense, but do we really need that in order to process the deactivate? As per the PAd agreement, it says, we need a written notice. I do agree, that maybe in future, we need a place to upload those written notices. But we can take a look at that requirement when we see the volume of such requests. Till that point, these written notices can go into the existing physical filing system

@mstanton1 - Let me know what you think.

mstanton1 commented 3 years ago

@jyoti3286 I am on board with the proposal from above. As far as the form I can check if we have a ticket and if not I will create one, that BA's can work on when time allows. There is a very similar form that was used by the BCOL Admin team to close Electronic cheque and Auto EFT that we'd reviewed earlier and could use as the basis for this work so I don't anticipate creation of that form being large effort.

jyoti3286 commented 3 years ago

@mstanton1 Sounds good.

@sumesh-aot I will add the Accpetance Criteria

jyoti3286 commented 3 years ago

@sumesh-aot - Acceptance Criteria is updated for Account name validation

sumesh-aot commented 3 years ago

@jyoti3286 This is a rare scenario : Should we allow accounts to be deleted if they have an invoice partially paid? This would happen an invoice is paid partially with online banking ?

jyoti3286 commented 3 years ago

@sumesh-aot Do we release the documents till we have received the final payment? I don't think we do.

sumesh-aot commented 3 years ago

@jyoti3286 No, we release only when payment is received in full.

sumesh-aot commented 3 years ago

Moved AC 7 and 8 to https://github.com/bcgov/entity/issues/8046

SateeshFW commented 3 years ago

Released to PROD. Moving it to CLOSED.