Prevent user from starting alteration if "Not In Good Standing"

sienna-oldaccountdontuse commented 3 years ago

On Entity dashboard, when user clicks draft alteration Check last AR filed date to see if company in good standing (if there is an oustanding Annual Report, then the date they click on the draft alteration must be within 2 months and 1 day from the anniversary date of incorporation) If company not in good standing, display message for user to contact BC Registries.

For example: Anniversary date is April 1. If their draft alteration was put onto their to do list on March 27th, a 2021 AR would display in the dashboard on April 1st. If the user attempts to file the alteration between April 1st and June 2nd they are in good standing. If they attempt to file the alteration after June 2nd they are no longer in good standing and need to contact Registry staff.

The backend doesn't currently provide this status (good standing / not in good standing). See ticket 6928 for this status Backend validation in case the front-end tries to file something not in compliance

Open questions:

If we put this on the button click, we would need multiple requests. Can we disable this before the click?

This estimation is for the front end work. See 6928 for back end.

TESTING NOTES

All of these business are under BCREG0018, Pass: 98918
BC1230105 - Limited Company NOT IN GOOD STANDING with a REQUIRED Alteration
BC1230111 - Limited Company IN GOOD STANDING with a REQUIRED Alteration BC1230001
BC1230001 - Benefit Company IN GOOD STANDING with a DRAFT Alteration

lmcclung commented 3 years ago

@lmcclung to update when a corporation is deemed to be not in good standing. - updated with MVP definition of when company not in good standing.

jordiwes commented 3 years ago

Question for @lmcclung :

This does not disable the "change company info" button in the Entity Info header, which is how existing companies start an alteration (other than changing business type). Should it?

lmcclung commented 3 years ago

@jordiwes yes, it should.

jordiwes commented 3 years ago

@lmcclung Are change of directors and/or change of address allowed?

sienna-oldaccountdontuse commented 3 years ago

Good question Steph!

If there is a draft, the client can not start any other filings (including directors and addresses)
If the client has an alteration draft, same thing, they cannot start any other filings.
If the client has an alteration draft, and are not in good standing, not only can they not file any other filings because of the draft, but also can't file the alteration draft.

So to answer your question, correct, they cannot file a director or address change. But not because of the "not in good standing" status, it's because they have a draft open.

@lmcclung what do you think? Maybe we want to rethink that, but it makes sense to me

severinbeauvais commented 3 years ago

~If there are any UX or QA questions, I will answer them.~ See other comments below.

jordiwes commented 3 years ago

See business https://dev.bcregistry.ca/business/BC1218829 for a business not in good standing :)

forgeuxGH5 commented 3 years ago

Hey @jordiwes what's the account info to access the business? BCREG...

forgeuxGH5 commented 3 years ago

Entity type should be the type they are altering from - should not be Benefit Company until after alteration
Filing label should be "Alteration - BC Limited Company to a BC Benefit Company" to match the ledger/history item label (post alteration)
Button label is "Alter now", single action button to match the "mandatory filing" pattern used for Annual Reports
"Alter now" button is displayed in the same row as the filing label
Instructional/help text wraps at right edge of "Alter now" button
If the current grey text is consistent with other filings keep it, if this grey is only used here, prefer it to be darker (match text colour used in filing type label)
Add blank line /padding above "To resolve this..."
The alteration section should not be actionable - in dev it currently has a link mouse cursor and expands the item on click (it shouldn't do this).
Bold text for "This business is not in good standing."
If the icon and text colour for "This business is not in good standing." are consistent with this component in other filings keep them. If not, prefer this to use our latest validation designs using "Error Red" #D3272C
Also prefer to display the red alert line on the left of the item
Add some padding between the contact labels and the phone numbers email

cameron-eyds commented 3 years ago

@forgeuxGH5 Morning Scott! Where can i find a link to the visual designs screen captured above? I checked the epic/story and couldn't seem to find it.

forgeuxGH5 commented 3 years ago

@cameron-freshworks we haven't been doing visual design for the dashboard (other than the company details / tombstone)... sadly... what's in the screenshot is pretty much what's in the wireframes, here's a link though https://preview.uxpin.com/fac96ab3f3769b5940b0444784eb73a2b2606b0e#/pages/131618287/simulate/sitemap

cameron-eyds commented 3 years ago

Excellent, thanks sir!

cameron-eyds commented 3 years ago

@forgeuxGH5 @tlebedovich

This is back into UX. I put some TESTING NOTES in the comments above.

Those businesses are the scenarios currently expected / handled for the changes. This definitely feels like an iterative process at this time (some unknowns), so don't hesitate to ask for more changes.

tlebedovich commented 3 years ago

Leaving this one for @forgeuxGH5 to review

forgeuxGH5 commented 3 years ago

Just want to confirm that if the user starts the alteration, saves it without filing, then they enter the not in good standing stated that we will display the "Resume" button on the To do item in the dashboard.

So it would have the dimmed/disabled segmented "Resume" button like this:

Otherwise, the dashboard view for this ticket (Not in Good Standing) looks good (per BC1230105 - Limited Company NOT IN GOOD STANDING with a REQUIRED Alteration)

The behaviour for the Company information page view and returning to the business dashboard needs to be changed per BC1230111 - Limited Company IN GOOD STANDING with a REQUIRED Alteration BC1230001

Do you want to look at that in this ticket here or move this along?

severinbeauvais commented 3 years ago

Do you want to look at that in this ticket here or move this along?

New ticket please, as that is in a different app.

forgeuxGH5 commented 3 years ago

Sure - should probably be a bug ticket. @cameron-freshworks if you can confirm the above behaviour then this ticket is good to go.

sienna-oldaccountdontuse commented 3 years ago

@severinbeauvais @forgeuxGH5 to confirm, you need a new ticket for the EDIT UI (alteration filing)? @lmcclung where should we put that, after I make it?

severinbeauvais commented 3 years ago

to confirm, you need a new ticket for the EDIT UI (alteration filing)?

Yes.

I'm guessing this refers to the breadcrumb component at the top of the info header, ie... "Company Information > Review and Certify" "Business Profile > Review and Certify"

The wireframe linked above shows various different things... We need to specify the exact changes needed.

forgeuxGH5 commented 3 years ago

Yes - new ticket but maybe let's check everything once things are in test - the issues I was seeing were related to the behaviour of the dashboard To Do item button not matching the state of the Company Information page. I was looking at Cam's work in dev so I'm not sure if the issues are sorted in test or being QA'd.

sienna-oldaccountdontuse commented 3 years ago

I have created this new ticket for the other Edit UI work: https://app.zenhub.com/workspaces/entity-5bf2f2164b5806bc2bf60531/issues/bcgov/entity/7423 @forgeuxGH5 please link your designs :) then I will update the AC

bcgov / entity

Prevent user from starting alteration if "Not In Good Standing" #6923