search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Filings UI: due date does not display #7079

Closed severinbeauvais closed 3 years ago

severinbeauvais commented 3 years ago

Describe the bug in current situation Found while testing #7074:

  1. go to https://test.bcregistry.ca/business/BC0879726
  2. log in with BCREG0020
  3. observe error

image.png

Link bug to the User Story None.

Impact of this bug Unknown.

Chance of Occurring (high/medium/low/very low) Unknown.

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps? Unknown.

Steps to Reproduce See description above.

Actual/ observed behavior/ results See description above.

Expected behavior As a user managing a benefit company When my annual report is due Then I expect to see a valid due date.

Screenshots/ Visual Reference/ Source See description above.

severinbeauvais commented 3 years ago

This is a BComp I just created. To see the "File 2021 Annual Report" todo item, I went in the database and changed the founding date to 1 year ago. As far as I know, there is nothing else to update to fake a BComp incorporated 1 year ago, so this should be a valid test.

severinbeauvais commented 3 years ago

I have investigated this. The issue is a date conversion bug.

The solution should include a refactor of date mixin functions to make them similar to the functions in Edit UI and Namerequest UI (which are more up to date). I started work on this but had to park it. If possible, work should resume from here: https://github.com/severinbeauvais/business-filings-ui/commits/7079

Note that the date refactor includes some standardization of date formats between the Entity UIs. @forgeuxGH5 This is your chance to clean up some date formats! (Eg, display "Apr 12, 2021" instead of 2021-04-12.)

severinbeauvais commented 3 years ago

@forgeuxGH5 see updated comment above

severinbeauvais commented 3 years ago

I cannot reproduce this problem in Dev or Test. (And the example business above in Test no longer exists.)

However, there are still some date methods worth updating...

severinbeauvais commented 3 years ago

Although I picked away at this in between higher priority tasks, it took longer than expected due to verifying everything locally.

severinbeauvais commented 3 years ago

Testing Notes:

The major change implemented is new code to convert and display dates and times. (The mixin containing this code was basically ported over from our other projects, so it's not "all-new" code, it's actually "new-to-this-project" code.)

As a result of these changes, please verify the following:

  1. Filing History List - please verify the title (label) and receipt downloads for each filing type affected:

    • AR filing date and time in ledger (and also future effective date)
    • Alteration filing date and time in ledger (and also future effective date)
    • "other" filing date and time in ledger
    • Correction filing date and time
    • COLIN filing date and year
    • Transition filing date and time (and also future effective date)
    • Paper filing date and time

  2. Todo List:

    • BCOMP AR todo task (next AR date + AR due date)
    • confirm cancel payment dialog

  3. Details (comments) list (timestamp)

  4. NR info for draft IA (expiration date)

  5. AR filing

    • BCOMP date + today's date
    • effective date (in POST call)
    • misc dialogs

  6. Correction filing

    • original filing date
    • corrected filing date (in POST call)
    • misc dialogs

  7. Standalone Directors filing

    • COD date (initial and when resuming a draft)
    • effective date (in POST call)
    • misc dialogs

  8. Standalone Office Addess filing

    • effective date (in POST call)
    • misc dialogs
severinbeauvais commented 3 years ago

NB: @forgeuxGH5 and @tlebedovich has a quick look at a screenshot and say it looks good / the dates work well. Do you guys want to review this in more detail (in Dev)?

tlebedovich commented 3 years ago

visual design wise i don't need to see it in action so its all ok for me, but @forgeuxGH5 might?

severinbeauvais commented 3 years ago

@lmcclung What do you think about adding this ticket to the Registrar's Notation release? Or should it wait until the next release (which isn't planned yet btw)?

cc: @riyazuddinsyed

forgeuxGH5 commented 3 years ago

Looks good to me - this is really nice.

severinbeauvais commented 3 years ago

Hi @forgeuxGH5 . This is now deployed to Dev. Have a look and please move this ticket to RFQA if you're satisfied. Thanks!

severinbeauvais commented 3 years ago

Ah, whoops. As I was verifying in Dev, I found a bug (related to staff comment display). You can still have a look, bugfix won't change anything else. Fixing now...

severinbeauvais commented 3 years ago

The bug with staff comment dates is now fixed. This is again deployed to Dev.

I'm moving this directly to RFQA as Scott already had a look at this.

severinbeauvais commented 3 years ago

More Testing Notes

As THIS ticket requires verification of many pages and filing types, you may consider testing #7357 at the same time (as THAT ticket also requires verification of many pages and filing types).