bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Logging out of NR UI doesn't log me out of BCROS #7085

Closed severinbeauvais closed 3 years ago

severinbeauvais commented 3 years ago

Describe the bug in current situation Found while testing #7074:

  1. go to https://test.bcregistry.ca/business/auth/home/
  2. log in (eg, with BCSC)
  3. go to https://test.bcregistry.ca/namerequest/
  4. click [name] -> Log Out
  5. observe that you appear to be logged out
  6. again, go to https://test.bcregistry.ca/business/auth/home/
  7. observe that you are still logged in !!!

Another symptom of this issue is: (same steps 1 - 5)

  1. create a NR and pay for it (Pay BC)
  2. when you return to NR UI, observe that you are now logged in !!!

Link bug to the User Story None.

Impact of this bug User cannot correctly log out. May be a security issue. May cause session data / cookie problems.

Chance of Occurring (high/medium/low/very low) Easy to reproduce.

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps? Found in Test.

Steps to Reproduce See description above.

Actual/ observed behavior/ results See description above.

Expected behavior As a user When I log out Then I expect to really be logged out.

Screenshots/ Visual Reference/ Source None.

jdyck-fw commented 3 years ago

@mstanton1 & @amit4610 - can you please bring this up with your team?

mstanton1 commented 3 years ago

@jdyck-fw we did not get to this one in grooming today. Can it wait until our next grooming (April 27 or 29)?

jdyck-fw commented 3 years ago

@mstanton1 - This needs further review to confirm expected behaviour, and then to be ready for mid-May (15-20th)

ghost commented 3 years ago

Developers will look and come back with suggestions @saravanpa-aot

severinbeauvais commented 3 years ago

This no longer reproduces in Dev. It may have been fixed by #7304.

mstanton1 commented 3 years ago

@Milan-Freshworks can you please verify this is not occurring for you either? If so we can close it. Thanks!

janisrogers commented 3 years ago

@severinbeauvais Does this still happen in Test?

severinbeauvais commented 3 years ago

"Logging out of NR UI doesn't log me out of BCROS" no longer happens in Test.