search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Able to file many Incorporation Applications by affiliating a single Name Request. #7296

Open riyazuddinsyed opened 3 years ago

riyazuddinsyed commented 3 years ago

Describe the bug in the current situation

When a user Affiliates the NR, then the user is able to file more than one Incorporation Application thereby getting multiple BC Benefit Companies

Impact of this bug All users affiliating the NR

Steps to reproduce the behavior:

  1. Go to 'https://dev.bcregistry.ca/business/auth/account/2079/business'
  2. Click on 'Mint corps'
  3. Start an IA. Get an identifier.
  4. Start the other IA
  5. see an error.
lmcclung commented 3 years ago

Two potential issues:

1) Temporary ID for IA isn't going away in MB dashboard after incorporation - 1 day 2) NR not being consumed - see 6033

jdyck-fw commented 3 years ago

This could potentially result in further work around consuming the NR.

Mihai-QuickSilverDev commented 1 year ago

@kzdev420 Kevin, do you have what you need to work on this ticket?

kzdev420 commented 1 year ago

Hi @Mihai-QuickSilverDev @riyazuddinsyed

First, I need to reproduce the issue locally. I want you guys to help me with that. Where is the Mint corps?

kzdev420 commented 1 year ago

Hi @riyazuddinsyed

This is the error you are seeing for this task? Private Zenhub Image

jdyck-fw commented 1 year ago
  1. Test to see if we can file multiple IAs that use the same NR.
  2. Once the NR is consumed, determine what happens to the original IAs (do they have a warning sign in My Business Registry?)
  3. Connect with @davemck513 to confirm intended behaviour as @janisrogers spoke to this morning at scrum. We may not want to prevent this.
severinbeauvais commented 1 year ago

It may still be possible to have a race condition, as the NR is not marked as consumed until the Filer processes it, which could be up to 2 weeks in the future (future effective IA). During this time, another IA could probably be filed with the same NR.

I suspect only the first IA to consume the NR will succeed and the others will fail... Kevin will test this per Jason's comments above.

janisrogers commented 1 year ago

Is it possible to mark the NR as consumed as soon as it is payed for?

severinbeauvais commented 1 year ago

As soon as the IA is paid for? Hmm, maybe.

@vysakh-menon-aot , which component handles the payment right now? The same component that checks the NR state?

And what would we do if a future effective IA fails to be completed (by the Filer)? I guess we'd have to refund them and reset the NR?

vysakh-menon-aot commented 1 year ago

entity-pay (queue) mark a filing as paid once it receive confirmation.

severinbeauvais commented 1 year ago

Thanks. And how is entity-pay triggered to process the payment? Is it as soon as the filing is submitted, or when the Filer processes it?

vysakh-menon-aot commented 1 year ago

entity-pay receive a notification from pay-api (or one of the queue in pay) if the payment is processed successfully (right after a filing is submitted).

severinbeauvais commented 1 year ago

OK, that's good news. Would it make sense, and would it be easy, to mark a NR as consumed as soon as pay succeeds (right after a filing is submitted)?

vysakh-menon-aot commented 1 year ago

It is possible. We need to confirm this with business and @thorwolpert

kzdev420 commented 1 year ago

In the first account, NR was converted into a Business.

In the second account, I was not able to Resume the Draft and got an error Invalid Incorporation Application. An unexpected error has occurred. ...

So, I reloaded the page, and after refreshing the page, NR was not shown.

severinbeauvais commented 1 year ago

It is possible. We need to confirm this with business and @thorwolpert

@Mihai-QuickSilverDev Can you help with this, please?

severinbeauvais commented 1 year ago

In the first account, NR was converted into a Business.

In the second account, I was not able to Resume the Draft and got an error Invalid Incorporation Application. An unexpected error has occurred. ...

So, I reloaded the page, and after refreshing the page, NR was not shown.

What does the second IA look like on My Business Registry page?

Can you show the page without the NR please?

kzdev420 commented 1 year ago

Hi @severinbeauvais

https://dev.account.bcregistry.gov.bc.ca/account/2079/business BCREGA001/98900001 NR was NR 6856351

Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

jdyck-fw commented 1 year ago

This is not ready to work on, we need business input for how this will go.

severinbeauvais commented 1 year ago

Kevin, please try this:

  1. create a NR
  2. in one account, affiliate the NR and use it to create a draft IA
  3. in another account, affiliate the NR and use it to create a draft IA
  4. in first account, file the IA
  5. in second account, what does the draft IA look like in MBR? can you resume it?
Mihai-QuickSilverDev commented 1 year ago

@thorwolpert Question for you: Could we mark the NR Consumed as soon as the client clicks File and Pay, or do we need to wait until the filing is complete? - This would apply to Future Effective Date filings. We are trying to prevent the NR being used by another IA, while waiting on an FED for the first IA.

ozamani9gh commented 1 year ago

@PCC199 ticket is in backlog on entities team. Just on our board for visibility

severinbeauvais commented 5 months ago

@Mihai-QuickSilverDev This ticket has been well investigated and we are waiting for guidance from Thor on whether it is acceptable to mark the NR as consumed as soon as payment is confirmed (instead of after the IA is processed by the Filer, which could be 2 weeks in the future). If this is OK then the risk of using the same NR for 2 different IAs is very small -- the time between filing an IA and paying for it (pay queue issues notwithstanding). From a business point of view, is that an acceptable risk?

severinbeauvais commented 4 months ago

This is the same issue as 21698.