bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

pass the return url [dashboard url] to sbc-header to support modified account creation flow - Entities #7757

Open saravanpa-aot opened 3 years ago

saravanpa-aot commented 3 years ago

Who will do this work

Entities team

As a part of https://github.com/bcgov/entity/issues/6921 , account creation flow is getting modified and user can cancel the creation of new account and get back to one of the older accounts he has.

Each team can decide which url user should be taken back to if they decide to abort the account creation flow .For auth , it is home page . sbc-header accepts a parameter dashboardReturnUrl which other team can leverage.

Expected Behaviour - Acceptance Criteria

Things to do

  1. Update the sbc-common-components version

  2. Pass the variable dashboardReturnUrl to sbc-header as necessary. This could be a discussion within the team on where to navigate the user to .If the team is okay with user going back to home page , no need of passing in the url.

impact if you do not get this item

The user will be taken to the default page which is the auth home page.

More details of the implementation can be found in the original ticket https://github.com/bcgov/entity/issues/6921

sienna-oldaccountdontuse commented 3 years ago

@saravanpa-aot is there any work for the entities /assets team as part of this ticket?

saravanpa-aot commented 3 years ago

Yes @Sienna-Blumstengel This is a dependency ticket which is related to ticket 6921. The things to do are in the ticket description :-)

mstanton1 commented 3 years ago

@saravanpa-aot should we have a dependency ticket for each team? Is the question where each team would like the user to land if they are presented with the multiple accounts screen and choose to go back?

My thought is a user would expect to go to the homepage of the app they are in - e.g. if I'm in names, start account creation, and opt out I should go back to https://www.bcregistry.ca/namerequest.

saravanpa-aot commented 3 years ago

@saravanpa-aot should we have a dependency ticket for each team? Is the question where each team would like the user to land if they are presented with the multiple accounts screen and choose to go back?

My thought is a user would expect to go to the homepage of the app they are in - e.g. if I'm in names, start account creation, and opt out I should go back to https://www.bcregistry.ca/namerequest.

Yes @mstanton1.Each team needs a dependency ticket. You are right , it's the place where user to land if they take the second option . Each team can decide where they want the user to go back to.

mstanton1 commented 3 years ago

@Sienna-Blumstengel can you work with your team to determine where a client should be redirected if they have an existing account, choose to start creation of a new account, and then cancel out of that new account creation request.

Note for Auth it is the homepage.

URL required for flow if initiated from Name Request.

sienna-oldaccountdontuse commented 3 years ago

Entities team has decided to send the user back to whatever page they were on previously

mstanton1 commented 3 years ago

@Sienna-Blumstengel if there is just one page they always return to your devs will need the URL. If there are different flows I've been advised that your devs can implement logic on your side.

Saravan noted: the page just goes back to whatever you were on last -> that will be challenging for them..their dev has to code to find out which page user is on and pass it to our component.

To implement logic he mentioned

So they pass this url to that header component and header component has logic to route back to that url… the header compoenent lives with in the each application passing this url -> upto them..they can pass google.com and the component can take them to google.com

Once expected behavior is defined you'd need to work with @lmcclung to determine when your team wants to do this work. Until implemented if a client is in names and cancels out of the account creation flow they will be redirected to the auth homepage.

sienna-oldaccountdontuse commented 3 years ago

@severinbeauvais @doug-lovett how much effort would it be for our teams to do what Melissa and Saravan have described above? We need to do work on our side in order for them to take us back to the page we were last on.

severinbeauvais commented 3 years ago

First, note that, in Name Request, we cannot send the user back to whatever page they were on previously, because Name Request has no notion of routes to particular pages, or of saving temporary data the user has entered.

However, to add a property to the sbc-header component used in Name Request, which specifies Name Request's main URL to return to, is pretty easy... say 1-2 hours. Meng has already provided an example in https://github.com/bcgov/entity/issues/6921#issuecomment-853458746.

sienna-oldaccountdontuse commented 3 years ago

@lmcclung thoughts on the above? Impact of the ticket is very low, we can just send the client back to the homepage. I do know we want to implement Severin's above suggestion anyways, but don't know how high priority that is.