search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Delete All button in Alterations does not delete the filing. #7965

Open riyazuddinsyed opened 3 years ago

riyazuddinsyed commented 3 years ago

Describe the bug in the current situation When a user starts an Alteration Filing and after making changes when the user hits on the "Delete All" button then instead of deleting Alteration filing the state is just pushed to the Draft which can only be deleted from that point.

Impact of this bug All users wanting to delete the Alteration filing.

Steps to reproduce the behavior:

  1. Go to 'https://dev.bcregistry.ca/business/auth/home/decide-business' 2.Start an Alteration Filing.
  2. Make changes 4.Delete the filing. 5.see an error

Design comps: https://projects.invisionapp.com/share/SB11NFJVTAN7#/screens?browse

jdyck-fw commented 3 years ago

Sev believes this is likely as per designed, could you please confirm? @forgeuxGH5 @tlebedovich

tlebedovich commented 3 years ago

This is for @forgeuxGH5 to double confirm but the design intent from my pov was:

1) If this is a brand new alteration (not resuming a draft alteration) the Delete and Delete all button (both currently do the same thing) on review and confirm screen would serve the warning modal as it does and if they proceed with the deletion, it should delete the alteration (not save a draft), and serve the users with the "Deleted" state of the review and confirm screen as shown here: https://invis.io/2W10ACX7VNE4#/445482337_09c_Certify_And_Review_-_Deleted

(no-fee based changes will be saved)

2) If this is a user resuming a Draft alteration and they make additional alteration changes and hit Delete or Delete all on review and confirm, I assumed it would also delete the entire draft and any new changes they made have (aside from no fee changes) as well? I would think so. Can you confirm @forgeuxGH5

(no-fee based changes will be saved)

jdyck-fw commented 3 years ago

@forgeuxGH5 - We are waiting your designs before triaging this further.

jdyck-fw commented 3 years ago

Please review when you get a chance @forgeuxGH5

jdyck-fw commented 3 years ago

@forgeuxGH5 - now that you're back, curious for your input on a design here please.

jdyck-fw commented 3 years ago

Sienna following up with Scott on this one

forgeuxGH5 commented 3 years ago

Should work as described by @tlebedovich

jdyck-fw commented 3 years ago

Leaving this for next triage for review with @lmcclung , as this seems to be a feature update rather than just a bug. Sev remembers us discussing this and deciding not to do the delete from here, just the dashboard.

tlebedovich commented 3 years ago

@jdyck-fw - however the work gets done is totally fine with me, but to note, the way we described is how it was originally designed. here are the design comps, I can include them in the description above for whomever takes on this ticket - https://projects.invisionapp.com/share/SB11NFJVTAN7#/screens?browse