BUG - Weasy Print PDF Outputs no longer displaying correct BC Sans Font

[tlebedovich]

It was discovered that the PDF outputs using Weazy print are no longer properly displaying our custom BC Sans font. They are rendering using a default font (they were correctly displaying the BC Sans font previously).

This is affecting the PDF outputs for Relationships, PPR and Entities that we saw in both DEV, TEST as of today, July 29, 2021.

Info gathering notes (from @doug-lovett):

• In the WeasyPrint documentation for the current report-api version, 52.5, woff and woff2 fonts are not supported. I am running 53.0 beta locally and woff fonts work (BC Sans) when created locally. It uses the PayBC API.

How to recreate the problem: 1) go to https://test.bcregistry.ca/namerequest/ 2) go to Manage My Name Request tab 3) look up NR7605740 / tracey@gloriousday.com 4) On summary screen, download receipt 5) open PDF receipt in Acrobat, in edit mode highlight a word and the Font will display as DejaVu instead of BC Sans

Sample receipt output from Name Request: https://app.zenhub.com/files/157936592/4b6fa7c9-6676-4698-89e7-7e960be93eea/download

[tlebedovich]

@doug-lovett @severinbeauvais - I opened this bug ticket - if you had anything to add, feel free to add it above.

fyi - @lmcclung @Kaineatthelab @jyoti3286

[lmcclung]

@doug-lovett @severinbeauvais when fixing this, would work need to be done on each pdf or is it something that can be fixed at a global level?

[severinbeauvais]

That depends on what's broken!

[severinbeauvais]

(The font spec for our outputs is in a common file, if that's what needs to be changed.)

[lmcclung]

@Kaineatthelab @jyoti3286 I propose that we tackle this when we update each email template or maintain a filing if it's not a common file.

[tlebedovich]

Because it was working a few weeks ago, I have a feeling it may even be a bug with the Weazy print software - maybe their most recent update messed something up. Worth a call with their support folks before we dive in deep on our side.

[tlebedovich]

@jyoti3286 - Here is that Weazy Print BC Sans font bug we had talked about early for you to look at. It is effecting all of the PDF outputs. @lmcclung had mentioned that there was a recent update made to the official BC Sans gov't font so that may have something to do with the reason why its no longer working. It was working previously.

[sienna-oldaccountdontuse]

@thorwolpert is this a configuration issue with weasy print? Which team should investigate this issue?

[tlebedovich]

I thought @jyoti3286 and relationships was going to fix this? Can we confirm.

[jyoti3286]

@tlebedovich - we haven't looked into this yet. There was some other PDF output raised by the Assets team which was fixed.

@shabeeb-aot - On a high level, would you know what's happening here?

[shabeeb-aot]

@jyoti3286 I did a quick research . We are adding BCSans font in PDF. we may need to research

[lmcclung]

@jyoti3286 to see if they can include this in sprint 10.5. If not, then 10.6 please.

[tlebedovich]

@mstanton1 - Any updates on the font issue?

[mstanton1]

@Kaineatthelab I believe you were going to see if SRE could take on this work. Is that correct? Any updates?

[Kaineatthelab]

@jyoti3286 team should do the work @pwei1018 mentioned

[jinghualicgi]

@mstanton1 Melissa will bring this to PO Syc

[jinghualicgi]

Will follow-up with Thor on Dec17 or ask Kaine on Dec20

[jinghualicgi]

Will need Patrick Wei's support, waiting for Jan when he returns

[pwei1018]

This is ready for QA.

[mstanton1]

@pwei1018 thank you! This will go to UXA. Will the update show on existing PDFs or just those generated moving forward?

cc @tlebedovich

[jinghualicgi]

@pwei1018 Hi Patrick, can you provide and estimate for this ticket? Thanks

[tlebedovich]

@mstanton1 @pwei1018 - is this ready for UXA? if so can we move to UXA column please.

Patrick - will this fix already previously existing PDFs (if we download them again) or just new ones moving forward?

[mstanton1]

Moved to UX Assurance / Verification

[tlebedovich]

@Kaineatthelab @lmcclung @mstanton1 @pwei1018 - BC Sans seems to be rendering find now for PPR search/registration (yay!). This ticket was originally to fix the font also for Name Request/Business Registry and Relationship outputs. Should we create a new bug ticket for everything else other than PPR and move this along?

[mstanton1]

@tlebedovich @pwei1018 to confirm, if there actually still work to update this in each of the other apps from the dev side or is it just UXA that is needed in those?

[tlebedovich]

@pwei1018 @mstanton1

Ok I did a bit more sleuthing and it looks like the dev work may have been done for PPR, Entities and Name Request, but not Relationships.

I downloaded a few examples from the Business Registry - Address Change/Director Change/NOA/Business Summary - and these outputs all look correct, but I noticed the Receipts that appear within Business Registry (that come from relationships) aren't fixed - they still display DEJA as the default font.

And the Name Request Results PDF (which comes from Name Request) is correct but the Receipts in Name Request are not.

[mstanton1]

@pwei1018 is there a separate update needed in auth to tackle the auth flow and receipts? If so, if it's quick it'd be great to push with this. If not, I can create a ticket for tackling it later.

Thanks for the extra review @tlebedovich

[pwei1018]

@tlebedovich It seems receipt is using BC Sans font but other reports not.

https://github.com/bcgov/sbc-pay/blob/main/report-api/report-templates/payment_receipt.html

https://github.com/bcgov/lear/blob/main/legal-api/report-templates/template-parts/style.html

[tlebedovich]

@pwei1018 - that's the opposite of what I saw when I downloaded the PDFs from Dev yesterday. I'll ping you this afternoon and we can jump on a call.

[mstanton1]

@pwei1018 @tlebedovich did you end up jumping on a call to discuss? Let me know the outcome so I can ensure any other required tickets are created.

[pwei1018]

@mstanton1 I did the code fix for the receipt. Don't need the new ticket.

[pwei1018]

@tlebedovich this ticket is ready for QA in dev and test.

[tlebedovich]

thanks @pwei1018 - BC Sans in now appearing in the receipts. BUT, some of the text headers that used to be bold, are no longer showing as bold. @mstanton1 - we could move this ticket along and make a bug ticket, or try to fix now - up to you. let me know.

Patrick - here is the example (on the right) of the bold that is missing now that BC Sans is turned on for receipts:

[mstanton1]

@tlebedovich yes please. The issue sounds minor. For the bug, @pwei1018 are receipts handled in auth? If so I will log it with dependency on relationships.

[tlebedovich]

@mstanton1 - ok moving the RFQA if you can log that small ticket please with the screenshot above. thanks.

[pwei1018]

@mstanton1 @tlebedovich I can fix this issue. Don't bother to create a new ticket.

[pwei1018]

Fixed in dev.

[mstanton1]

@tlebedovich can you please UXA the flow above?

[tlebedovich]

@pwei1018 - in your comp above, when I compare it to my UXA mock up above;

• company name "THE BRAMBLES..." header in top blue bar should be bold as well
• only "Payment Method:" and "Invoice Number:" at the bottom should be bold, the words "Credit Card" and "REG00006541" should not be bold.

but again, not high priority for MVP

[pwei1018]

@mstanton1 @tlebedovich Ok, I will leave it. Melissa can you create bug ticket to relationship team. They can fix the issue.

[chdivyareddy]

@mstanton1 moving this to Done.