Create UI - S1&S4 - custodian address

[lmcclung]

To Do:

• [x] Build new component
• [x] Build changes depending on entity type
• [x] Save values to store, apply these to the filing
• [x] Build review page step 4 UI

COOPS

• [x] title of component "Custodian of Records"
• [x] tool tip text says "A Cooperative Association must appoint a person to have custody and control of its records, including documents, instruments and accounting records, for 2 years."
• [x] Instructional text says "Enter the full name, email address and mailing address of the Custodian of Records. Addresses must be located in Canada." ~- [ ] user can select if they are a liquidator or a custodian of records with a radio button. Hide fields until they select.~
• [x] Title of person/role in the component is "Custodian of Records"
• [x] Has mailing and delivery address

CORPS

• [x] title of component "Custodian of Records"
• [x] tool tip text says "Section 351 of the Business Corporations Act requires that a custodian be responsible for the care and custody of a dissolved company's records for 2 years."
• [x] Instructional text says "Provide the full name, email address, and mailing address of the Custodian of Records who will be responsible for the care and custody of the company's records."
• [x] must be a custodian, no selection to choose liquidator or custodian.
• [x] Title of person/role in the component is "Custodian of Records"
• [x] Has mailing and delivery address

[sienna-oldaccountdontuse]

@Sienna-Blumstengel @forgeuxGH5 define corp text

[lmcclung]

Converted estimate to fib.

[cameron-eyds]

@tlebedovich Hola! Ready for UXA whenever you have time, no rush, thanks!

[tlebedovich]

@cameron-freshworks - Here is my UXA:

Coops/Corps - Step 1

• [x] Corps Helper Text - please change the second "two" to say "2" so it matches the other "2" in the first sentence.

• [x] Coops intro text needs update please:

• [x] CORPS - Both the Province and Country were supposed to be a) uneditable and b) pre-populated with BC and Canada (with dotted line) as per design comp (this was something I understood was going to be doable in this ticket? If so, should the Canada Post look up then we restricted to BC Canada look up only?). Should we chat? Right now Province defaults to not pre-populated and Country defaults to Canada but you can change it to any other country. Its odd to give users choices that they aren't allowed to choose.

• [ ] COOPS - Canada should be pre-populated and uneditable with dotted line (Province stays as a dropdown)

• [ ] Address Error Bug 1- Also - at one point I was able to Choose "Quebec" as the Province in Step 1, went to Step 4, where it had triggered the "This step is unfinished" error message, but when I returned back to Step 1 to see what the error was, it wasn't highlighting the Quebec province as being the error (so user wouldn't know what it was that they needed to fix)

• [ ] Address Error Bug 2 - I typed 555... and used the Canada Post look up to select 555-76 Rue Dalhousie, The Province filled in as "Quebec" with the province must be in bc error. Then I went to change the country from Canada to Cameroon, and the Province changed to a Province/State text input field that says "QC" instead of the province dropdown with "Quebec" - and the province error message turned off.

• [x] Error message - change to "Corporation or firm name is required"
• [x] Error messages - change to "First name is required" and "Last name is required"

• [x] Funky invalid Space error - If the FML Names/Corporation Name error validation gets triggered after going to Review Step 4, when I return to Step 1 and start typing a company name with normal spaces between multiple words, its giving me an "Invalid spaces" error anytime I type a space (before I start typing the next word) when it shouldn't. Yet it doesn't give me the invalid space error if I type several spaces between the words. If a user accidentally leaves an extra blank space at the end of its name, we should just remove it for them. Same if the user adds extra spaces between words - we should just remove the extra spaces for them. Don't think the spaces errors are needed if were remove double spaces and spaces at the end of the name for them anyway.

• [ ] P3 Delivery Instruction input field boxes seems not as tall as the normally are?

• [x] P3 Align left edge of Gray Box with Edge of hairlines above it

Coops/Corps - Step 4

• [x] Align COR column content with the ones above
• looks like the "Name" and "Mailing Address" bold headers in the first column could move left a couple pixels to align, and then to whole second column should align with "Phone Number" column above

• [x] Need a minimum of 20px gutter space between column content

Corps/Coops - Saving Draft (save and resume later)

• [x] Error - Checkbox not staying saved When I select "Delivery Address same as Mailing Address" in Step 1 and select to Save and Resume Later, and then from the dashboard, I open the Vol Diss draft to continue, the "Delivery Address same as Mailing Address" check box is no longer checked and both addresses are expanded. It should save the user's checkbox selection.
• [ ] When you open up a draft Vol Diss from your dashboard, the error messages that you had already triggered are no longer there when you open it up again (you have to re-trigger them again) - was this intentional?

[cameron-eyds]

@tlebedovich Thanks for the review, a lot of this is easily adjustable! With regards to the common component changes, that would take some time and work in SBC-Common-Components. The jist, the address form specifically is a common component utilized all over the applications so it's consistent. We can add some new props features to try and do what you're asking but that will take some more time. I'm not sure how the address complete can be modified or if we can limit the interactions in the way proposed but we can definitely try. If that work was to be done here in this ticket, i didn't see common component work called out specifically, so we might have to look at this and groom a ticket to do so.

With regards to the error states when returning from draft, we typically save the values not the flags or computed values that indicate invalid states, they are usually prompted after a user leaves a step that is invalid, goes to review page or tries to file etc. Saving the validity of each individual piece is not something we've done before, is this how we would like it here and every where else? If so, we will need a ticket and to groom it.

Can definitely update the Delivery Same as Mailing checkbox being preserved in a draft, that was my misunderstanding. I saw that the default was to be open, so made it as such.

[tlebedovich]

Thanks Cameron

1. Yes to saving the address check box in the Draft.

2. If you aren't saving Draft's validations in other apps then let's keeping this one working the same way.

3. Re: common component address- I assumed because we spec'd province/country as being pre-populated and non-editable in the designs/grooming that the work to make that happen would be included. But lets ask Linda at standup or team demo today so she can see the errors/user issues I listed and she can decide how to proceed. But it's functionality most apps need now so in my opinion, worth the effort.

[cameron-eyds]

Sounds good. Currently working on all the other updates. Will use the checkboxes you've provided, thank you!

[tlebedovich]

@cameron-freshworks - new item (I will review the others soon)

• [x] I noticed on the Review screen, under Delivery Address, it says "Same as Mailing Address" as the default by mistake, when the "Same as Mailing Address" check box is NOT selected in Step 1.

[cameron-eyds]

@cameron-freshworks - new item (I will review the others soon)

• [x] I noticed on the Review screen, under Delivery Address, it says "Same as Mailing Address" as the default, when the "Same as Mailing Address" check box is not selected in Step 1.

Because they are always the same by default when no values have been entered. This is a result of us defaulting some values (ie Country and Region). The current logic compares the two addresses and will display as such if they are the same but we can let the checkbox dictate this state, sounds like you prefer the latter? I did ask about this previously but we can change it to show the incomplete address if thats what is preferred.

[tlebedovich]

hi @cameron-freshworks - Sorry, I don't remember you asking me about this. I didn't know it had that logic - is this logic used in other UIs? It's not wrong per say (actually kind of cool), just not what I was expecting without having checked the box. I'm ok to leave it if you guys are already using this elsewhere.

And then of course while I was checking it out, I noticed we are missing the delivery instructions displaying on Step 4 (which should appear as italics, 14px like this;

[cameron-eyds]

Its alright, i probably didn't articulate it well enough! We can use the checkbox to dictate that display there, however if the user has the same address in both mailing and delivery but without the checkbox selected it would display the full address, not the same as.

Ah interesting, will look into the sample text, that was missed.

[tlebedovich]

@cameron-freshworks @riyazuddinsyed - Looks good to proceed to RFQA. There are still some funky address bugs (see unchecked items below), but I think the user can still make it thru their filing ok so Linda mentioned to leave it for now, unless you see additional issues Riyaz.