bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Create UI - S2 & S4 - Sample Resolution #8913

Closed lmcclung closed 2 years ago

lmcclung commented 2 years ago

To do:

COOPS

nothing for step 4 for this ticket

~CORPS do not need Step 2~ CORPS will have this step

Note: when building the filing for special resolution, the resolution field which is a required field can just have a placeholder value to ensure the filing will pass schema validation.

lmcclung commented 2 years ago

Needs to be regroomed - when we first groomed it we said there wouldn't be a step 2 for corps.

argush3 commented 2 years ago

@lmcclung would I be able to get the sample special resolution pdf(form 06 COO) that should be downloaded?

@tlebedovich do you have a preview image i can use for this? For now I'm just using a screenshot I've taken from the designs.

tlebedovich commented 2 years ago

@argush3 the link to the png image should be in the design ticket.

argush3 commented 2 years ago

@tlebedovich thanks.

tlebedovich commented 2 years ago

And to note @argush3 and @lmcclung, there is a Step 4 review component to this step, will it be done in a separate ticket?

argush3 commented 2 years ago

@tlebedovich I think it was intended that we do the review component in this ticket as well. i'll update the description of this ticket to include it.

argush3 commented 2 years ago

@tlebedovich just some questions about whether we should title case some of the text in the Coop and Corp designs for step 2 of voluntary dissolutions. I've included two screenshots of the specific text where i wanted to get confirmation regarding title casing. let me know when you have a minute. thanks

Corps image.png

Coops image.png

tlebedovich commented 2 years ago

hi @argush3 - yes, capitalization rules are often not 100% consistent, but we decided to not capitalize these items as they are more generic terms versus a title. So they are ok as is.

argush3 commented 2 years ago

@lmcclung during the internal team demos, @thorwolpert brought up some points that probably require some discussion around special resolutions for voluntary dissolutions. Based off of my interpretation of the comments from Thor, here are some of the things that require more discussion:

argush3 commented 2 years ago

Decision was made to:

BE updates/work will be done in #8914

@lmcclung I realized we will likely need a bunch of text/label updates as well as removal of the sample section. I've included a screenshot below of updates that might be needed. Maybe you could go through them and get me the label/text updates required and point out any assumptions I've made that may be wrong?

Also I've provided two potential resolution text field options that follow some of the existing designs I could find. I did this figuring that maybe @tlebedovich could make a quick decision on which one she likes or if she wants something entirely different. Otherwise, I will go with option 1.

image.png

yuisotozaki commented 2 years ago

@lmcclung Please confirm that Step4 "Certify" component content is equivalent to the Certified Correct field set content in the form. I.e. we don't need a separate field for neither a person or date on Step 2. Coop Special Resolution Screenshot 1.png

lmcclung commented 2 years ago

@yuisotozaki @tlebedovich @argush3 We need to collect who signed the resolution and what date they signed it so we can put it on the output. It wouldn't be a certify section though, like it is on the form. The person who signed the resolution would most likely not be the person who is filing the dissolution.

Tracey, I just spoke with Argus. He'll reach out to you to let you know where he's thinking of putting the fields on the page.

tlebedovich commented 2 years ago

@argush3 - please ping me when you have something to review for this step and the review step and Yui and I can take a look and provide any feedback. Thank you :)

argush3 commented 2 years ago

will do @tlebedovich. I'm working on corresponding backend changes right now but I will definitely touch base early...before I get too deep into implementation for it to be difficult to pivot.

sienna-oldaccountdontuse commented 2 years ago

Requirements document updated https://docs.google.com/document/d/1pJM2mUoG5ln6eiopole3BY5PBAExESBGz4cRYdnDG58/edit?usp=sharing , see the requirements for special resolution

tlebedovich commented 2 years ago

@yuisotozaki @forgeuxGH5 @lmcclung @sienna-blumstengel Argus just caught me up with this and it seems like a really odd user experience to have folks download and fill out a form, only to have them copy and paste (or rewrite) that same information into an online form? Let's catch up Monday and chat quickly regarding this.

c/c @argush3

To discuss:

special resolution.png

tlebedovich commented 2 years ago

@argush3 and @lmcclung (c/c @yuisotozaki) - Here are the updated design comps for Step 2 Coops as well as what it should look like on Step 4 Review screen (with and without errors).

I used "Signing Party" for the person that signs the resolution form - let me know if that works.

Updated Special Resolution Coops Designs:

https://projects.invisionapp.com/share/UY120PIZVB4J#/screens?browse

argush3 commented 2 years ago

@tlebedovich I am still working on some things from a code perspective but I believe the functionality is in place for you to take a look in DEV. I just wanted to get some feedback as early as possible while I finish things up.

I've created two voluntary dissolution filings(corp and coop) that you can use in DEV under BCSC user BCREG0018 - https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/create-resolution?id=BC0870738 and https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/create-resolution?id=CP3490182

tlebedovich commented 2 years ago

UXA for you @argush3

STEP 2

Tool Tip

Screen Shot 2021-11-25 at 2.45.41 PM.png

Resolution Date

Screen Shot 2021-11-30 at 10.51.40 AM.png


Screen Shot 2021-11-30 at 10.55.51 AM.png

Screen Shot 2021-11-25 at 2.55.33 PM.png Screen Shot 2021-11-25 at 3.14.13 PM.png

Resolution Text:

Resolution Signature

Screen Shot 2021-11-25 at 3.29.02 PM.png Screen Shot 2021-11-25 at 3.30.39 PM.png

Confirm Special Resolution

Screen Shot 2021-11-25 at 3.35.51 PM.png

STEP 4 - REVIEW

And it showed this: Screen Shot 2021-11-25 at 3.51.07 PM.pngScreen Shot 2021-11-25 at 3.51.14 PM.png

argush3 commented 2 years ago

@tlebedovich the changes you requested should be in DEV and ready for another review from you. we are still waiting for the updated sample doc though. @lmcclung @sienna-blumstengel any ETA on when we will get an updated doc or if we will get one?

lmcclung commented 2 years ago

@argush3 @tlebedovich I noticed in the date picker the warning message isn't very user friendly. Can it state the actual incorporation date? "Date should be between 2021-11-01 and 2021-11-29 (or whatever date format is best)?
image.png

tlebedovich commented 2 years ago

@lmcclung - the user should never see that message - they should only be allowed to select the appropriate dates from the picker (non-valid dates should be grayed out) - maybe you can let @argush3 know exactly how you got to that error message? (fyi, we should try to use November 12, 2021 as the date format whenever space allows)

lmcclung commented 2 years ago

@tlebedovich thanks Tracey. It also wouldn't let me file it with today's date. @argush3 perhaps we can chat in the morning?

argush3 commented 2 years ago

@lmcclung yes, we can talk in the morning.

When you say you can't file with today's date, do you mean you can't dissolve on the same date as a company is incorporated? If that's what you mean, I came across this issue. I incorporated a new coop and tried to dissolve it right away. I need to go back to the dashboard, select the coop and then it would let me dissolve it.

As for the error message("Date should between null (incorporation date) and 2021-11-29"), Tracey had mentioned this before too but I don't really expect that to happen. It's possible from older voluntary dissolution filings that didn't populate the incorp date. With the work for this ticket I populated the incorp date into the initial draft filing. So if you were using an older dissolution filing it would explain why you are seeing that error. There is still a possibility that there is a bug though. If you could let me know which coop and account you were using, I could check if it was an older filing without the incorp date.

lmcclung commented 2 years ago

@argush3 No, I had incorporated a couple weeks ago and was trying to put in a resolution date of today. Ah, it was an old draft so I deleted it and don't have that error now. but I have a new one... for the date the resolution was signed, it would only let me enter today's date, not a date in the past. It needs to be able to select a date in the past or today.

image.png

argush3 commented 2 years ago

@lmcclung I think I know what the issue is for the "date signed". The logic of what dates to allow for selection for signed date field currently looks at what date is selected in the resolution date field. If none is selected then only the current date is provided as an option. When a resolution date is selected, the allowed date range changes to selected resolution date to today. Do we want it to work such that if no resolution date is selected that we would just use the range of incorp date to today for the signing date field?

tlebedovich commented 2 years ago

@lmcclung Are we getting an updated SR PDF for Argus to include? One that doesn't have the old mail-in instructions?

tlebedovich commented 2 years ago

@argush3 - looking great. There are two empty checkboxes in my feedback comment for you to review, and then fixing the date selection issues with Linda. I will move this to In Progress for you.

argush3 commented 2 years ago

@tlebedovich at standup today @lmcclung said that we can go with what we have for now. Including the updated SR pdf will be future work.

lmcclung commented 2 years ago

@argush3 leave the logic the way it is. This is correct as the signature date can't be before the resolution passed date. I couldn't replicate my scenario either. I must have had Nov 29th as the SR date up top so it restricted the date below to being Nov 29th only. @tlebedovich not sure of the ETA for the new Special Resolution form so we'll just go with what we have for now.

argush3 commented 2 years ago

@tlebedovich the 2 outstanding checkbox items should be addressed now and ready for testing in DEV. The resolution date one should not be something that you can create via the UI so I modified the dev db manually to create that scenario. I've included screenshots of both dates (resolution and signing date) when the validation error has been triggered in DEV.

image.png

image.png

tlebedovich commented 2 years ago

this is great, thanks @argush3 - moving along to RFQA.

argush3 commented 2 years ago

@riyazuddinsyed you can use the following coop to test the special resolutions step. user is BCREG0018

https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/create-resolution?id=CP3490182