Closed lmcclung closed 2 years ago
Needs to be regroomed - when we first groomed it we said there wouldn't be a step 2 for corps.
@lmcclung would I be able to get the sample special resolution pdf(form 06 COO) that should be downloaded?
@tlebedovich do you have a preview image i can use for this? For now I'm just using a screenshot I've taken from the designs.
@argush3 the link to the png image should be in the design ticket.
@tlebedovich thanks.
And to note @argush3 and @lmcclung, there is a Step 4 review component to this step, will it be done in a separate ticket?
@tlebedovich I think it was intended that we do the review component in this ticket as well. i'll update the description of this ticket to include it.
@tlebedovich just some questions about whether we should title case some of the text in the Coop and Corp designs for step 2 of voluntary dissolutions. I've included two screenshots of the specific text where i wanted to get confirmation regarding title casing. let me know when you have a minute. thanks
Corps
Coops
hi @argush3 - yes, capitalization rules are often not 100% consistent, but we decided to not capitalize these items as they are more generic terms versus a title. So they are ok as is.
@lmcclung during the internal team demos, @thorwolpert brought up some points that probably require some discussion around special resolutions for voluntary dissolutions. Based off of my interpretation of the comments from Thor, here are some of the things that require more discussion:
resolution
. As we did not have a text field in the designs, the decision we made was to just have the front end to pass placeholder text when submitting a COOP voluntary dissolution filing. Thor - it seems like you think we should include a text field for the user to input the resolution text in the UI?Decision was made to:
BE updates/work will be done in #8914
@lmcclung I realized we will likely need a bunch of text/label updates as well as removal of the sample section. I've included a screenshot below of updates that might be needed. Maybe you could go through them and get me the label/text updates required and point out any assumptions I've made that may be wrong?
Also I've provided two potential resolution text field options that follow some of the existing designs I could find. I did this figuring that maybe @tlebedovich could make a quick decision on which one she likes or if she wants something entirely different. Otherwise, I will go with option 1.
@lmcclung Please confirm that Step4 "Certify" component content is equivalent to the Certified Correct field set content in the form. I.e. we don't need a separate field for neither a person or date on Step 2.
@yuisotozaki @tlebedovich @argush3 We need to collect who signed the resolution and what date they signed it so we can put it on the output. It wouldn't be a certify section though, like it is on the form. The person who signed the resolution would most likely not be the person who is filing the dissolution.
Tracey, I just spoke with Argus. He'll reach out to you to let you know where he's thinking of putting the fields on the page.
@argush3 - please ping me when you have something to review for this step and the review step and Yui and I can take a look and provide any feedback. Thank you :)
will do @tlebedovich. I'm working on corresponding backend changes right now but I will definitely touch base early...before I get too deep into implementation for it to be difficult to pivot.
Requirements document updated https://docs.google.com/document/d/1pJM2mUoG5ln6eiopole3BY5PBAExESBGz4cRYdnDG58/edit?usp=sharing , see the requirements for special resolution
@yuisotozaki @forgeuxGH5 @lmcclung @sienna-blumstengel Argus just caught me up with this and it seems like a really odd user experience to have folks download and fill out a form, only to have them copy and paste (or rewrite) that same information into an online form? Let's catch up Monday and chat quickly regarding this.
c/c @argush3
To discuss:
@argush3 and @lmcclung (c/c @yuisotozaki) - Here are the updated design comps for Step 2 Coops as well as what it should look like on Step 4 Review screen (with and without errors).
I used "Signing Party" for the person that signs the resolution form - let me know if that works.
https://projects.invisionapp.com/share/UY120PIZVB4J#/screens?browse
@tlebedovich I am still working on some things from a code perspective but I believe the functionality is in place for you to take a look in DEV. I just wanted to get some feedback as early as possible while I finish things up.
I've created two voluntary dissolution filings(corp and coop) that you can use in DEV under BCSC user BCREG0018 - https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/create-resolution?id=BC0870738 and https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/create-resolution?id=CP3490182
UXA for you @argush3
STEP 2
Tool Tip
Resolution Date
[x] Resolution Date - Something may be not 100% right with the date picker. Dates earlier than the coop's inc date should not selectable in the date picker - user shouldn't see an error like this because we shouldn't let them pick an invalid date. I tried again and didn't see this error, so something to test a bit more (see screenshot below)
[x] Just in case users do see this error, let's fix it to show this: "Date should be between November 11, 2021 and November 29, 2021"
Resolution Text:
Resolution Signature
[x] fields should align with right edge of date/text fields:
[x] missing period:
[x] Signing Date Picker -- Same updates to this date picker as mentioned above
[x] Default field text should be 495057 but looks lighter in these places (I noticed it may be lighter in step 3 affidavit upload field text as well- doh):
Confirm Special Resolution
STEP 4 - REVIEW
[x] Confirm text colours, some look off - all body copy items should be 495057, side bold headers should be 212529
[x] Remove the extra white space:
[x] Resolution text is getting cut off and not showing the full text. I typed this:
And it showed this:
@tlebedovich the changes you requested should be in DEV and ready for another review from you. we are still waiting for the updated sample doc though. @lmcclung @sienna-blumstengel any ETA on when we will get an updated doc or if we will get one?
@argush3 @tlebedovich I noticed in the date picker the warning message isn't very user friendly. Can it state the actual incorporation date? "Date should be between 2021-11-01 and 2021-11-29 (or whatever date format is best)?
@lmcclung - the user should never see that message - they should only be allowed to select the appropriate dates from the picker (non-valid dates should be grayed out) - maybe you can let @argush3 know exactly how you got to that error message? (fyi, we should try to use November 12, 2021 as the date format whenever space allows)
@tlebedovich thanks Tracey. It also wouldn't let me file it with today's date. @argush3 perhaps we can chat in the morning?
@lmcclung yes, we can talk in the morning.
When you say you can't file with today's date, do you mean you can't dissolve on the same date as a company is incorporated? If that's what you mean, I came across this issue. I incorporated a new coop and tried to dissolve it right away. I need to go back to the dashboard, select the coop and then it would let me dissolve it.
As for the error message("Date should between null (incorporation date) and 2021-11-29"), Tracey had mentioned this before too but I don't really expect that to happen. It's possible from older voluntary dissolution filings that didn't populate the incorp date. With the work for this ticket I populated the incorp date into the initial draft filing. So if you were using an older dissolution filing it would explain why you are seeing that error. There is still a possibility that there is a bug though. If you could let me know which coop and account you were using, I could check if it was an older filing without the incorp date.
@argush3 No, I had incorporated a couple weeks ago and was trying to put in a resolution date of today. Ah, it was an old draft so I deleted it and don't have that error now. but I have a new one... for the date the resolution was signed, it would only let me enter today's date, not a date in the past. It needs to be able to select a date in the past or today.
@lmcclung I think I know what the issue is for the "date signed". The logic of what dates to allow for selection for signed date field currently looks at what date is selected in the resolution date field. If none is selected then only the current date is provided as an option. When a resolution date is selected, the allowed date range changes to selected resolution date to today. Do we want it to work such that if no resolution date is selected that we would just use the range of incorp date to today for the signing date field?
@lmcclung Are we getting an updated SR PDF for Argus to include? One that doesn't have the old mail-in instructions?
@argush3 - looking great. There are two empty checkboxes in my feedback comment for you to review, and then fixing the date selection issues with Linda. I will move this to In Progress for you.
@tlebedovich at standup today @lmcclung said that we can go with what we have for now. Including the updated SR pdf will be future work.
@argush3 leave the logic the way it is. This is correct as the signature date can't be before the resolution passed date. I couldn't replicate my scenario either. I must have had Nov 29th as the SR date up top so it restricted the date below to being Nov 29th only. @tlebedovich not sure of the ETA for the new Special Resolution form so we'll just go with what we have for now.
@tlebedovich the 2 outstanding checkbox items should be addressed now and ready for testing in DEV. The resolution date one should not be something that you can create via the UI so I modified the dev db manually to create that scenario. I've included screenshots of both dates (resolution and signing date) when the validation error has been triggered in DEV.
this is great, thanks @argush3 - moving along to RFQA.
@riyazuddinsyed you can use the following coop to test the special resolutions step. user is BCREG0018
To do:
COOPS
nothing for step 4 for this ticket
~CORPS do not need Step 2~ CORPS will have this step
Note: when building the filing for special resolution, the
resolution
field which is a required field can just have a placeholder value to ensure the filing will pass schema validation.