FAS : Routing Slip Error Messages - Filings UI

[lmcclung]

Error messages for Routing Slip in Business Registry/Name Request

TO DO:

• create common Staff Payment Dialog (similar to Assets - see this)
  • [x] use shared Staff Payment component
  • [x] fix validation bugs in Staff Payment component
  • [x] fix colours in Staff Payment component
• [x] move COD Certify component from edit page to review page (delete read-only version)
• change in-page Staff Payment to dialog and display after "File and Pay" and allow drop-back to filing
  • [x] Annual Report
  • [x] Address Change
  • [x] Director Change
  • [x] Correction
• create and display common Staff Payment Error Dialog and allow drop-back to Staff Payment dialog
  • [x] Annual Report
  • [x] Address Change
  • [x] Director Change
  • [x] Correction
• [x] add/update unit tests as needed
• [x] fix bug where payment error dialog should be shown after File and Pay and before the redirect to the dashboard (all 4 filings)

Expected Behavior - Acceptance Criteria

Scenario 1: Routing Slip Not Active

• GIVEN that I am on the Staff Payments page while doing a filing
• WHEN I enter a Routing Slip number that is not active
• AND they click on "File and Pay"
• THEN I get an error message in a modal stating "This Routing Slip is not active"

Scenario 2: Routing Slip in linked

• GIVEN that I am on the Staff Payments page while doing a filing
• WHEN I enter a Routing Slip number which is in LINKED status
• AND they click on "File and Pay"
• THEN I get an error message in a modal stating "This Routing Slip is linked, enter the parent Routing slip:##"

Scenario 3: Routing Slip doesn't have enough balance

• GIVEN that I am on the Staff Payments page while doing a filing
• WHEN I enter a Routing Slip number that has not enough balance to process the filing
• AND they click on "File and Pay"
• THEN I get an error message in a modal stating "There is not enough balance in this Routing slip. The current balance is :$"

Scenario 4: Routing Slip Not found

• GIVEN that I am on the Staff Payments page while doing a filing
• WHEN I enter a Routing Slip number that is not yet created
• AND they click on "File and Pay"
• THEN I get an error message in a modal stating "Routing slip number has not been found"

Proposed Design

The below UX Pin has a design approach https://preview.uxpin.com/76da32cd3abd1eb16c96507294189fbd7bee9140#/pages/140210137/simulate/sitemap

• There is no real reason to follow the above pattern. It can be displayed in any other format(modal etc) which fits the current framework. We won't use this UX pin, just leverage existing modal used for BCOL/PAD errors.

Deadline

If possible in the next sprint, otherwise, the end of Oct should be OK.

Impact if deadline not met

Not a show stopper, but would be good to complete the story from our side(end to end)

Contact person

John Lane

[andrepestana-aot]

obsolete comment deleted

[lmcclung]

obsolete comment deleted

[andrepestana-aot]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[tlebedovich]

obsolete comment deleted

[tlebedovich]

@forgeuxGH5 @severinbeauvais

Buttons:

• the blue buttons on the bottom of the pages should say "Review and Confirm" for screen 1 (instead of Next) "File and Pay" (instead of File) to align with our other apps
• make the gray buttons use the blue outline style instead (all without drop shadows) if we are touching them

Staff Payment Modal Regarding the Staff Payment modal, it would look like the same as our others except with the checkbox and a general "Submit" button (instead of "Submit Name Request") like so:

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[severinbeauvais]

obsolete comment deleted

[forgeuxGH5]

obsolete comment deleted

[tlebedovich]

obsolete comment deleted

[severinbeauvais]

Test Notes

To verify for Director Change filing:

1. The Certify is moved from the edit page and to the review page.
2. The "next page" button is labelled "Review and Confirm" (and no longer has a tooltip).
3. The "prev page" button is labelled "Back".
4. The second page has a Save and Resume button beside the Back button.

To verify for all filings:

1. For all filings, as staff, the Staff Payment section is removed from in-page version and changed to a modal.
2. For all filings, as staff, the Staff Payment modal is displayed after the user clicks File and Pay.
3. For no-fee filings, the File button is labelled "File Now (no fee)".
4. After clicking Save, if there is a save error with error items or no items, a dialog is displayed ("Unable to Save XXX").
   • clicking Return to Filing closes the dialog
   • clicking Retry closes the dialog and tries to save again
5. After clicking Save, if there is a save error with only warnings, a dialog is displayed ("XXX Saved with Warnings").
   • clicking OK closes the dialog
6. After clicking Save and Resume Later, if there is a save error with error items or no items, a dialog is displayed ("Unable to Save XXX").
   • clicking Return to Filing closes the dialog
   • clicking Retry closes the dialog and tries to save and resume again
7. After clicking Save and Resume Later, if there is a save error with only warnings, a dialog is displayed ("XXX Saved with Warnings").
   • clicking OK closes the dialog and returns you to the dashboard
8. As a regular user, for a paid or no-fee filing, after clicking File and Pay, if there is a pay error, a dialog is displayed ("Unable to Process Payment").
   • clicking Back to My Dashboard closes the dialog and returns you to the dashboard
9. As a regular user, for a paid or no-fee filing, after clicking File and Pay, if there is a save error with error items or no items, a dialog is displayed.
   • clicking Return to Filing closes the dialog
   • clicking Retry closes the dialog and tries to file and pay again
10. As a regular user, for a paid or no-fee filing, after clicking File and Pay, if there is a save error with only warnings, a dialog is displayed.
    • clicking OK closes the dialog and redirects to PayBC (or dashboard if BCOL or no-fee)
11. As a regular user, for a no-fee filing, after clicking File and Pay, if there is a pay error, a dialog is displayed ("Unable to Process Payment").
    • clicking OK closes the error dialog
12. As a regular user, for a no-fee filing, after clicking File and Pay, if there is a save error with error items or no items, a dialog is displayed ("Unable to Save XXX").
    • clicking Return to Filing closes the error dialog
    • clicking Retry closes the dialog and tries to file and pay again
13. As a regular user, for a no-fee filing, after clicking File and Pay, if there is a save error with only warnings, a dialog is displayed ("XXX Saved with Warnings").
    • clicking OK closes the error dialog and redirects to dashboard
14. As a staff user, for a paid filing, after clicking File and Pay, a modal displays ("Staff Payment").
15. On the Staff Payment modal, initially no errors display.
16. On the Staff Payment modal, clicking Exit Payment closes the modal.
17. On the Staff Payment modal, with no option selected, clicking Submit "bounces" the modal and enables validation.
18. On the Staff Payment modal, before Submit is clicked, with any option selected, no validation errors are displayed.
19. On the Staff Payment modal, after Submit is clicked, with any option selected, any validation errors are displayed.
20. On the Staff Payment modal, after the form is completed and Submit is clicked, if there is a pay error, a dialog is displayed ("Unable to Process Payment").
    • clicking OK closes the error dialog
21. On the Staff Payment modal, after the form is completed and Submit is clicked, if there is a save error with error items or no items, a dialog is displayed ("Unable to Save XXX").
    • clicking Return to Filing closes the error dialog
    • clicking Retry closes the dialog and tries to file and pay again
22. On the Staff Payment modal, after the form is completed and Submit is clicked, if there is a save error with only warnings, a dialog is displayed ("XXX Saved with Warnings").
    • clicking OK closes the dialog and redirects to dashboard
23. Try an invalid RSN followed by a valid RSN, in order to test the fix for the bug that Yui found below.

---

From Andre's comment in 9221:

The following companies have been created for testing in dev as Staff: https://dev.bcregistry.ca/business/BC0870820 https://dev.bcregistry.ca/business/BC0870821 https://dev.bcregistry.ca/business/BC0870822

Using the routing slip to pay an alteration or a correction would display the message: 222222222 - Not active 123123123 - Not enough balance: $9.00 232323232 - Linked

Routing Slips can be edited/created on https://fas-dev.apps.silver.devops.gov.bc.ca/home

[severinbeauvais]

The SonarCloud Code Analysis check is failing due to excessive code duplication in AR/COA/COD/CORR filings as they are similar (and always have been but I just touched their code).

I do not know any easy or clean solutions to this issue, but I did a bit of research and it appears some solutions are becoming available. This work will be in a future ticket: 10572

[severinbeauvais]

Sample screenshot from Dev:

[yuisotozaki]

UXA Finding in https://dev.bcregistry.ca/ These visual differences were observed compared to the visual design attached in the comment above.

• The header colour is different from the visual design (and therefore the the title colour and close button colour)
• The Submit button is on the right hand side rather than left hand side like in the visual design and is inconsistent with the File and Pay vs Cancel on the main screen where the blue button is on the left of the two button set
• In field input validation, the field label is not in red like in the visual design

Logic wise, I'm not getting the individual error messages for each FAS slip scenario. They're all erroring out the same way.

[tlebedovich]

@yuisotozaki - Severin decided to keep the navy blue bar header which is consistent with the other modals, so thats ok the way he has it. And we have started to migrate the primary button to the right instead of left side (which makes sense especially when it moves you along the path), so i'm good with these differences.

I believe the fields/error validations themselves are already part of a shared component so that's probably also ok to leave as is (i keep hearing Kaine in my head saying - save money, save money, haha).

[yuisotozaki]

Then sounds like the visual aspect of UXA is good to go.

The error message, however, needs QA testing. Does this mean it passes UXA?

[severinbeauvais]

Thanks Tracey, all you said is correct.

As for the error dialog, you're not actually seeing the Pay Error dialog. What you're seeing is the Save Error dialog, due to a back end data bug. Try it again with a Coop or other Ben. Or look at the screenshot I posted above.

[yuisotozaki]

Got the error scenarios. Those expected scenarios pass UXA.

There is an additional scenario that's failing.

• Get to the payment modal
• Enter the 222222222 account and try to pay -> get the error -> acknowledge the error
• If you then enter another account number, the system errors out due to "another draft filing already exists"

It appears that a draft filing is saved when it errors out and the UI doesn't realize that it's the very same draft the user already has open.

[severinbeauvais]

~Hmm, the code should handle that but I'll have a look. It may be that the filing id is not available when there is a pay error.~

Update: This is a bug in the Filings UI. I will fix it ASAP as part of THIS ticket.

@lmcclung FYI

[severinbeauvais]

The bug above has been fixed, verified, and deployed to Dev and Test.

[yuisotozaki]

RFQA!