Golden Helipad NA's - Githubissues

DonnaHaga commented 1 year ago

R Version 4.3.1 envair version 0.4.0.100.

For Golden Helipad there are some entries with INSTRUMENT as NA along with many other columns.

# import data: hourly PM2.5 for the last 10 years
data<-envair::importBC_data(parameter_or_station = "pm25",
                            years=2014:2023,
                            use_openairformat = FALSE
                            )

# there are entries for instrument == NA in golden's data
data %>%
  dplyr::filter(STATION_NAME=="Golden Helipad") %>%
  dplyr::filter(is.na(INSTRUMENT))

goldenNAs

jeromerobles commented 11 months ago

data<-envair::importBC_data(parameter_or_station = "pm25", years=2014:2023, use_openairformat = FALSE )

data %>% dplyr::filter(station_name=="Golden Helipad") %>% dplyr::filter(is.na(instrument)) %>% nrow()

result is 0 rows.

DonnaHaga commented 11 months ago

Thanks @jeromerobles :). I tried again and also got zero rows this time. Weird.

How come the data you imported automatically get converted to lower case names and mine stay in caps? I used remotes::install_github("bcgov/envair") to make sure i have the most recent version. am i missing something?

jeromerobles commented 11 months ago

New update to keep the all caps column name as default.

From: Donna Haga @.> Sent: Friday, October 20, 2023 1:30 PM To: bcgov/envair @.> Cc: Robles, Jerome ENV:EX @.>; Mention @.> Subject: Re: [bcgov/envair] Golden Helipad NA's (Issue #19)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

Thanks @jeromerobleshttps://github.com/jeromerobles :). I tried again and also got zero rows this time. Weird.

How come the data you imported automatically get converted to lower case names and mine stay in caps? I used remotes::install_github("bcgov/envair") to make sure i have the most recent version. am i missing something?

— Reply to this email directly, view it on GitHubhttps://github.com/bcgov/envair/issues/19#issuecomment-1773354882, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALDDVQHUR2AXIEK4VUHH4TTYALNKVAVCNFSM6AAAAAA5RRHYNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGM2TIOBYGI. You are receiving this because you were mentioned.Message ID: @.**@.>>

DonnaHaga commented 11 months ago

all good to close now

bcgov / envair

Golden Helipad NA's #19