bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Display number of pages from AXIS in processing team queues #1684

Closed arielleandrews closed 2 years ago

arielleandrews commented 2 years ago

Assumptions & Scope

What is IN scope?

What is NOT in scope?

Acceptance Criteria

Scenario 1: Sync with AXIS - field is blank

Scenario 2: Sync with AXIS - field is populated

Scenario 3: Sync with AXIS - update populated field

Scenario 4: Sync with AXIS - Sync Review Changes

Scenario 5: Sync with AXIS - Complete Sync

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
arielleandrews commented 2 years ago

@abin-aot @divyav-aot @aparna-aot new user story drafted per discussion at stand up this morning. Let me know if any edits are required.

cc @lmullane @m-prodan @mpilchar @JHarrietha-AOT

lmullane commented 2 years ago

Looks good to me, @arielleandrews

m-prodan commented 2 years ago

@divyav-aot @aparna-aot

I believe you both worked on this one? It does not appear that I can test scenario 3, I can't add pages to an existing file right now.

Regarding scenario 2 - I may have found a bug. When there are multiple folders in document management, it only appears to count pages from one of the folders. I am not sure if its an issue with that particular file, or if we are pulling the wrong value? The file I used was FNR-2021-15044 - When I run the report for the field "Total # of pages in a request" - I can get the correct number of 2 pages, but once I sync it in the new system it only displays 1 page. That particular request had 2 folders though, and each had a single page. My other single-folder test cases worked as expected.

m-prodan commented 2 years ago

@divyav-aot @aparna-aot

I think this one may need to go back for further review. One of the issues is that there was no prompt or ability to sync the file to show the number of pages. Only if I added an extension, or made a change to the request details could I sync the file and then have the number of pages displayed.

When total # of pages has a value other than nil/0 - it should trigger a banner warning and allow for a sync. Should I update the AC or can you fix it with this comment? Let me know - moving back to review for your comments.

cc: @lmullane @KaraBeach @mpilchar

divyav-aot commented 2 years ago

@m-prodan we can update the banner display and modal for total no of pages. Please updated the AC.

m-prodan commented 2 years ago

@divyav-aot - AC Updated

cc: @lmullane

m-prodan commented 2 years ago

Blocked until FOI-MOD74 (AXIS bugs) are addressed by IMB - unable to add or remove pages to new or existing requests

mpilchar commented 2 years ago

@m-prodan Is this unblocked now that we are on 10.3?

m-prodan commented 2 years ago

Yup - going to try and tackle this one before I call it a day :)

m-prodan commented 2 years ago

QA passed - you all have no idea how excited IAO is going to be seeing this in action, I can't wait to demo this at the branch meeting on tuesday! Great work @divyav-aot