search

bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Filtering Comments #2433

Closed KaraBeach closed 2 years ago

KaraBeach commented 2 years ago

Assumptions & Scope What are the assumptions for this story?

When a user does a keyword search, all tabs will be searched no matter what tab they are on. What is IN scope?

What is NOT in scope?

Acceptance Criteria

Scenario 1: Searching 1 type of comments

Scenario 2: Searching All Comments

Scenario 3: 'User Comments default’

Scenario 4: 'Filter by ‘Request History Comments’

Scenario 5: 'Filter by ‘Divisional Tracking’

Scenario 6: 'Viewing new comments’

Scenario 7: 'Removing new comments indicator’

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @https://jacklyn808742.invisionapp.com/console/share/3W2O64AP5C/817813726

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
KaraBeach commented 2 years ago

@lmullane @m-prodan. I took an attempt to write this story, Please provide feedback

m-prodan commented 2 years ago

This looks good for your first go Kara - nice one. Some comments for consideration:

Scenario 1 and 2 - just needs a minor tweak to the "THEN" function - I think you put an extra comments in there.

Scenario 3 - include the additional "AND" you have in the other scenarios for sort order, with newest at the top.

Otherwise, it's probably in good enough shape for the devs to review, barring any further input from Loren. Thanks!

KaraBeach commented 2 years ago

@m-prodan- updated - thanks!

lmullane commented 2 years ago

Well written AC, Kara.

Do we also need an ‘All Comments’ so the user can search all comments by a keyword?

Sent from my iPhone

On Jul 7, 2022, at 2:33 PM, KaraBeach @.***> wrote:



[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

@m-prodan- updated - thanks!

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Ffoi-flow%2Fissues%2F2433%23issuecomment-1178252749&data=05%7C01%7CLoren.Mullane%40gov.bc.ca%7C386d0fe4215e4e4f34de08da60605ab1%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C637928264189343099%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NmXTPjcC6y%2F2eG3l%2Bh03%2BaJosDUJXb%2BSauyiL5PTJeM%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC33VB3LQCVPEFAZWP2KMMLVS5ELDANCNFSM526KB4EA&data=05%7C01%7CLoren.Mullane%40gov.bc.ca%7C386d0fe4215e4e4f34de08da60605ab1%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C637928264189343099%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YP4PQPJEtgIWv2vWYMi34vsXUHhy5Triv%2B5K91GrnaM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

KaraBeach commented 2 years ago

Hi Loren, I had ask Jackie about that and she had removed the “all comments” from the design based on user feedback as it was overwhelming to navigate.

Kara Beach ( she/her)

|FOI Specialist, Social / Tech Team | Information Access Operations | Ministry of Citizens’ Services Ph: 250 952-0361 | e: @.**@.> | m: PO Box 9569, Stn Prov Gov, Victoria BC V8W 9K1

I am grateful to have the opportunity to live and work in the traditional territories of the lək̓ʷəŋən People, known today as the Esquimalt and Songhees Nations. In sharing this space, I commit to be an ally in the important work of lasting reconciliation with Indigenous Peoples here and everywhere.

From: Loren Mullane @.> Sent: July 7, 2022 4:05 PM To: bcgov/foi-flow @.> Cc: Beach, Kara CITZ:EX @.>; Author @.> Subject: Re: [bcgov/foi-flow] Filtering Comments (Issue #2433)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

We’ll written AC, Kara.

Do we also need an ‘All Comments’ so user can search all comments by a keyword?

Sent from my iPhone

On Jul 7, 2022, at 2:33 PM, KaraBeach @.<mailto:@.>> wrote:



[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

@m-prodan- updated - thanks!

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Ffoi-flow%2Fissues%2F2433%23issuecomment-1178252749&data=05%7C01%7CLoren.Mullane%40gov.bc.ca%7C386d0fe4215e4e4f34de08da60605ab1%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C637928264189343099%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NmXTPjcC6y%2F2eG3l%2Bh03%2BaJosDUJXb%2BSauyiL5PTJeM%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC33VB3LQCVPEFAZWP2KMMLVS5ELDANCNFSM526KB4EA&data=05%7C01%7CLoren.Mullane%40gov.bc.ca%7C386d0fe4215e4e4f34de08da60605ab1%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C637928264189343099%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YP4PQPJEtgIWv2vWYMi34vsXUHhy5Triv%2B5K91GrnaM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.<mailto:@.>>

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Ffoi-flow%2Fissues%2F2433%23issuecomment-1178349387&data=05%7C01%7Ckara.beach%40gov.bc.ca%7Cf96bad9130244d43535108da606d0e4a%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C637928318746755556%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HnrKOcrWP7QUi0Wn8iXzAEKVK7O5dlPZqNOEr082z4E%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYOOALW5DJ2FSXDNH3CJS3LVS5PABANCNFSM526KB4EA&data=05%7C01%7Ckara.beach%40gov.bc.ca%7Cf96bad9130244d43535108da606d0e4a%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C637928318746755556%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Q4qu3QpP5Yo6cwTqYmR1p%2FnNd3VuMNTelWhvkiV8CqA%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

lmullane commented 2 years ago

@JHarrietha-AOT, @m-prodan, @arielleandrews,

With a keyword search I think the user will want to search one spot (i.e. All Comments) to get all the information related to that keyword.

For example, if I wanted to know how Harms were handled on a request, I would like want to know changes to state, division and comments.

Searching each tab would be more time consuming. Thoughts?

lmullane commented 2 years ago

As agreed:

abin-aot commented 2 years ago

As discussed over stand ups/refinement , "NEW COMMENT" is time based, as of now , its 2 days - configurable value.

arielleandrews commented 2 years ago

@JHarrietha-AOT please do UX Assurance on this ticket when you have a minute!

JHarrietha-AOT commented 2 years ago

@abin-aot I have one comment for UX assurance. There should be much less empty space around the filters.

This is what it currently looks like: ![Screen Shot 2022-08-11 at 12.51.55 PM.png] https://images.zenhubusercontent.com/6081a3ba692e484184671a59/80bcf21c-824a-405a-bf1a-ebc75038afd9

It should be closer to this: image.png

If you can increase the width of the search comment section to decrease the negative space on either side of the filters that would be great. Post here is this is a quick fix you can do now before the ticket is closed or if you would like a separate UX Assurance task

abin-aot commented 2 years ago

I will try to create a quick fix for this soon!

JHarrietha-AOT commented 2 years ago

Sounds good @abin-aot, maybe coordinate with @richard-aot as it is the same issue in the attachments search. And just tag me whenever its fixed and I can have a look and move everything through to Ready for QA

abin-aot commented 2 years ago

@richard-aot is fixing this UX issue on both components

richard-aot commented 2 years ago

@JHarrietha-AOT the width issue is fixed in dev environment. Please verify. Thanks.

JHarrietha-AOT commented 2 years ago

Passed UX Assurance Thanks for the Quick Changes @abin-aot & @richard-aot

KaraBeach commented 2 years ago

@abin-aot- your comment " As discussed over stand ups/refinement , "NEW COMMENT" is time based, as of now , its 2 days - configurable value."

Is that referring to AC #7, as I can't seem to get the comments to be read. I have tried, reply, clearing the notifications etc. Can you confirm?

All other AC's have passed- just #7 outstanding

KaraBeach commented 2 years ago

Confirmed at standup- that Scenario 7 is time based now- 2 days.

All AC's have passed review. Thanks! @abin-aot @richard-aot @JHarrietha-AOT