bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Angular App (Webform) Changes #3164

Closed m-prodan closed 1 year ago

m-prodan commented 1 year ago

Title of ticket: Angular App (Webform) Changes

Description

With the new Cabinet - there are some changes that need to be made to the angular webform, including conditional logic changes as some assumptions will have changed around how application fees are handled.

Name changes should apply to both the online form, the email submitted and the receipt generated.

Net new Ministries will follow the same logic for general request application fees - requests directed to them will incur a 10 dollar application fee.

Dependencies

N/A

DOD - Simple Name Changes:

DOD - REMOVE:

DOD - NEW Public Bodies/Ministries:

DOD - BC Services Card URL Updates:

On this page: image.png

TO: First time BC Services Card users: you will need to set up a BC Services Card account and verify your identity. Please input your email address when prompted.

TO: https://www2.gov.bc.ca/gov/content?id=B2B3A21E797A421A8FD39EEA86E245D6

m-prodan commented 1 year ago

Updates to online webform per new cabinet being sworn in today.

@arielleandrews - do you see any gaps? Anything not listed here is assumed to not be changing at all

cc: @lmullane @liseandtea @KyEggleston @abin-aot @JHarrietha-AOT

lmullane commented 1 year ago

@abin-aot, when you have time, could you add an estimate.

abin-aot commented 1 year ago

@lmullane done! - lets start with 8 . if required , I will inform and increase later

arielleandrews commented 1 year ago

Added one more name change. Looks good to go now! @m-prodan @lmullane @abin-aot

m-prodan commented 1 year ago

@arielleandrews Thank you!

@abin-aot - I have now included the URL/Text changes requested by the BCSC team.

lmullane commented 1 year ago

@abin-aot, these are the new org codes for the 2 new ministries:

HSG = Housing EMC = Emergency Management and Climate Readiness

Note, that from a reporting perspective all closed and inflight requests will remain with the original ministry (e.g. EMBC requests from before Dec 7th will remain PSSG).

New requests received from December 7th onwards will be under the new ministry (e.g., EMC).

Let me know if you have any questions?

cc @m-prodan

cc @m-

lmullane commented 1 year ago

For the future application, when an org change has occurred we need to keep sign off flexible. Sometimes the sign off will be done by the executive in the original ministry, sometimes by the executive in the new ministry.

In other words, we should not limit who is assigned as a reviewer based on the org code for the request.

abin-aot commented 1 year ago

@lmullane : If there is a change to existing codes of these ministries, say like JERI to JEDI

lmullane commented 1 year ago

@abin-aot, testing now.

Will need the ministries to be listed alphabetically.

lmullane commented 1 year ago

Hi @abin-aot, I have confirmed everything is working as expected.

However as above, the ministries should be listed alphabetically. Could you make that change?

abin-aot commented 1 year ago

@lmullane Yes, made that change as discussed. But just to indicate , earlier sorting was based on code , certain ministries was added in the middle - for some reason and for particularly for personal requests - Certain ministries like MCFD and Solicitor General will be come on top based on the previous selections on it. Now, I made it sorted as per the "NAME" of the public body and for personals - indicative ministries will be on top , then follows the alphabetical order. Make sense?

lmullane commented 1 year ago

All AC passed. Thanks, @abin-aot

abin-aot commented 1 year ago