bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Auto-flag Withheld in Full #3487

Closed lmullane closed 1 year ago

lmullane commented 1 year ago

Assumptions & Scope What are the assumptions for this story?

In AXIS when an analyst redacts an entire page, the 'Withheld in Full' flag is automatically added to the page.

In FOI Mod, when an analyst does the following, the 'Withheld in Full' flag will be automatically added:

ACs 3 and 4 are only for one page at a time.

What is IN scope?

Disable the manual selection of the 'Withheld in Full' flag.

Auto flag 'Withheld in Full' when a full page is redacted.

What is NOT in scope?

Redacting a full page when a 'Withheld in Full' flag is applied to a page.

Acceptance Criteria

Scenario 1: Automatically add 'Withheld in Full' flag when analyst redacts an entire page by page number

Scenario 2: Automatically remove 'Withheld in Full' flag when analyst removes full redactions from a page

Scenario 3: Click on 'Withheld in Full' flag in left panel

Scenario 4: Save FOIPPA section

Scenario 5: Manually Change Flag - Full Page Redaction

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team?s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
lmullane commented 1 year ago

@m-prodan, @JHarrietha-AOT

Please review the AC by end of day tomorrow and make any changes necessary.

Note, AC 5 to ensure that information is accurately redacted.

m-prodan commented 1 year ago

looks good to me

m-prodan commented 1 year ago

Updated AC's and revised assumptions and scope as per stand up this mroning

cc @aparna-aot

KyEggleston commented 1 year ago

@aparna-aot - These ACs pass.

The only small update, just to align with other redactions, is to change the default fill colour from black to white when applying a full page redaction.

Currently black fill: image

Other redactions are white: image

aparna-aot commented 1 year ago

@KyEggleston Sure. Will check and fix that soon. Thank you!

KyEggleston commented 1 year ago

Closing ticket, as all ACs pass - issue above regarding black fill in redaction box will be handled in a new bug ticket.