bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
4 stars 3 forks source link

Create Response Package and change redaction layers #3704

Open lmullane opened 1 year ago

lmullane commented 1 year ago

Assumptions & Scope What are the assumptions for this story?

Analysts need to be able to view different redaction layers.

The redline layer will be the default and will automatically be created when records are loaded into the Records Log. The redline layer will always be editable.

Analysts will create a Response Package layer in the menu.

Analysts will not be able to edit the Response Package layer; it will be view only. If analysts need to change the Record Package, they must edit the Redline layer first.

The purpose of the Response Package layer if for the analyst to review in the application the Response Package that will go or has gone to the applicant.

What is IN scope? Creating a Records Package layers

Toggling between Redlines and Records Packages.

What is NOT in scope? Saving the layers as PDFs are covered in, #3437, #3231.

Toggling between OIPIC, Open Info layers, Harms and Sign Off will be in a future story, #3735.

Acceptance Criteria

Scenario 1: Redaction Layer dropdown

Scenario 2: Click Redaction Layer dropdown

Scenario 3: Create first Records Package layer

Scenario 4: Create Records Package

Scenario 5: Click active Records Package in Redaction Layer dropdown

Scenario 6: Inactive Records Package in Redaction Layer dropdown

Scenario 7: Click Inactive Records Package in Redaction Layer dropdown

Scenario 8: Click active Redline in Redaction Layer dropdown

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
lmullane commented 1 year ago

@m-prodan, @JHarrietha-AOT

Please review this story AC.

@JHarrietha-AOT, could you clarify what the IAO Review, Harms and Ministry Sign Off layers are for in the design?

https://jacklyn808742.invisionapp.com/console/Redaction-cla8feezv003o015h7op82c5c/cleg4xqe55wt3018ba31e3cvi/play

Cc @liseandtea, @KyEggleston , @abin-aot

JHarrietha-AOT commented 1 year ago

@lmullane @m-prodan @liseandtea @KyEggleston

Changes based off of conversation at release planning https://jacklyn808742.invisionapp.com/overview/Redaction-cla8feezv003o015h7op82c5c/screens

Desired future state - for future ticket writing https://jacklyn808742.invisionapp.com/overview/Redaction-cla8feezv003o015h7op82c5c/screens

Let me know if you have any additional changes or if there was anything I missed from our conversation earlier

lmullane commented 1 year ago

@m-prodan and @liseandtea

Is there ever a scenario where an analyst will review and change the redactions in a Response Package? Or must they make the changes in the Redline first, and then create the Response Package?

liseandtea commented 1 year ago

@m-prodan @lmullane Yes, there are times when an analyst has to make changes to a response package once it has been closed. Usually, this is a breach situation. However, to make the changes, the request has to be re-opened in AXIS and the records moved from the "Request Folder" back to the "Review Log" in document management. The changes cannot be done while the request remains closed.

m-prodan commented 1 year ago

Need to figure out a way to break this up - per refinement, this is likely to be more than a 21, but less than a 40. Need to find the right way to split this story

m-prodan commented 1 year ago

Possible idea is to split this story up with one story being, create response package, and the second story being the switching between layers. Also need to square this story up with #3231 to ensure a consistent approach/UX.

Could also reduce to 21 and consider in conjunction with #3231 - but we still need to review both stories for consistency and possibly revisit at next refinement.

m-prodan commented 10 months ago

From what we can see - this story is likely currently being handled with the save response package story. Switching layers is already available. Removed from release 9.0