bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Redline Box and Mark as Single Object #4125

Open m-prodan opened 1 year ago

m-prodan commented 1 year ago

Assumptions & Scope This story is from our prioritization and feedback sessions with IAO Super Users.

Users found it difficult to remove redactions, this is because the annotation and the mark for the redline are drawn as two separate objects. This also clutters the redaction/annotation panel, as every redline will include two objects - the box itself, and the annotation.

To address this - we believe the annotation should be embedded into the redline object itself - this could be achieved by creating the annotation as a 'reply' to the redline/mark for redaction as that contains everything to a single object.

What is IN scope? Creating redlines using the box/selection tool Creating redlines for full page redactions Creating redlines for the find and redact feature from the redaction panel

What is NOT in scope?

Acceptance Criteria

Scenario 1: Mark for Redaction - box/selection tool

Scenario 2: Mark for Redaction - Full Page

Scenario 3: Mark for Redaction - Find and Redact

Scenario 4: Deleting Redaction Box

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
m-prodan commented 1 year ago

Assumption - there is no need for me to write a bug ticket around being able to delete a redaction box and annotation in a single click. This user story should eliminate that bug. Thoughts welcome @lmullane @liseandtea @KyEggleston

KyEggleston commented 1 year ago

It's a 'one or the other', so makes sense