bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
4 stars 3 forks source link

Create Redline for OIPC Review #4169

Open liseandtea opened 11 months ago

liseandtea commented 11 months ago

Assumptions & Scope This ticket reflects a new type of response package that can be created when an OIPC review layer has been added. the user must be on the OIPC review layer to have this option.

Other types of response packages will remain the same, and follow existing rules (Eg - Redline for Ministry Sign-Off and Response package for applicant.

What is IN scope? New Option for Creating a Type of Response Package - Redline for OIPC

What is NOT in scope? OIPC complaints such as:

Acceptance Criteria

Scenario 1: Creating an OIPC Review Layer

*Scenario 2: Creating an OIPC Review Layer**

Scenario 3: Adding an OIPC Review Layer

Scenario 4: Not adding an OIPC Review Layer

Scenario 5: Copying severing from Redline to OIPC Review Layer

Scenario 6: Changing severing on OIPC Layer

Scenario 7: Preparing an OIPC Review Layer to send to the OIPC

Scenario 8: Preparing an OIPC Review Layer to send to the OIPC that contains s.14

Scenario 9: Creating OIPC Review Package

Scenario 10: Redline locked when OIPC Review Layer created

Scenario 11: No Redline PDF can be created when OIPC Review Layer created

Scenario 12: Choosing not to prepare an OIPC Review Layer to send to the OIPC

Scenario 13: Cancelling OIPC Review Package

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
liseandtea commented 11 months ago

Developing the AC

liseandtea commented 11 months ago

@m-prodan @KyEggleston Feedback please lads! Starting to go down the rabbit hole on this one... Some of the language will need changing/updating depending on designs and how FOI Mod App will trigger OIPC review layers in the redaction app (once we get to that stage). Also, I am wondering if we need the OIPC layer at all? Thinking in more simple terms, not all requests have an OIPC review, and an analyst will be required to download a what was sent to the applicant anyway. Could that record of decision not be saved and the analyst can use the same redline layer? If that was the case then we would really only need the section 14 stories - an option that could be triggered once the file was flagged as "OIC" in Mod.

m-prodan commented 10 months ago

After giving this a quick review - I think scenarios 1-5 are captured in #4191 - currently in progress. Really all we need for this story is to focus specifically on creating a redline to send to the OIPC, which unlike Ministry sign-off, needs an option (defaulted to yes) where any redlines that have s. 14 will be redacted. Scenarios 6-10 should cover this for the most part.

cc @lmullane

Aman-Hundal commented 8 months ago

Refinement Questions for 4169 and 4170

FE and BE changes needed. Dev team will come up with better estimates and refinement after the above.

Aman-Hundal commented 8 months ago

Follow up notes:

liseandtea commented 8 months ago

@JHarrietha-AOT Hey! Do these updates match your new flow/language?

JHarrietha-AOT commented 7 months ago

No designs - this is validations for what should and should not happen appear for Redline - UI will be the same as precious redline processes

divyav-aot commented 7 months ago

Refinement Comments: when can IAO download the redline? is there any extra validation needed? - Not needed. Default validation is enough. New dropdown value for the stitching - Redline for OIPC Review

sumathi-thirumani-aot commented 7 months ago

This has an open question on when to copy the redactions from redline to OIPC. Listed are the options

  1. Click on the button component "+ oipc"
  2. When the reopened request has OIPC Review flag added with review type as "Review".
  3. When the reopened request has been moved to state "Records Review".

In correspondence to discussion on 04 Dec with @JHarrietha-AOT

sumathi-thirumani-aot commented 6 months ago

Suggestion : Can we make this option font color little darker. It looks like disabled; whereas it is not. @JHarrietha-AOT @KyEggleston

image.png
sumathi-thirumani-aot commented 6 months ago
  1. System allows changing of page flags for "Redline" after moving to "OIPC redactions". This should not be allowed.
sumathi-thirumani-aot commented 6 months ago
  1. System does not allow selection on sections at the top of modal due to UX issues. I believe this is introduced as part of OIPC. image.png
KyEggleston commented 6 months ago

Suggestion : Can we make this option font color little darker. It looks like disabled; whereas it is not. @JHarrietha-AOT @KyEggleston image.png

I don't see why this couldn't be darker font. Provided all the conditions are met to produce an OIPC redline, it can share the colour/HEX as other active options (e.g., same as the active 'Redline for Sign Off' option in the image below):

image

nimya-aot commented 6 months ago

Scenario 10 is failing . Able to edit when we switch to 'Redline' layer after OIPC layer is created. Also scenario 11 failing, "Redline for sign off" button is enabled. @sumathi-thirumani-aot could you please check?