Open liseandtea opened 11 months ago
Developing the AC
@m-prodan @KyEggleston Feedback please lads! Starting to go down the rabbit hole on this one... Some of the language will need changing/updating depending on designs and how FOI Mod App will trigger OIPC review layers in the redaction app (once we get to that stage). Also, I am wondering if we need the OIPC layer at all? Thinking in more simple terms, not all requests have an OIPC review, and an analyst will be required to download a what was sent to the applicant anyway. Could that record of decision not be saved and the analyst can use the same redline layer? If that was the case then we would really only need the section 14 stories - an option that could be triggered once the file was flagged as "OIC" in Mod.
After giving this a quick review - I think scenarios 1-5 are captured in #4191 - currently in progress. Really all we need for this story is to focus specifically on creating a redline to send to the OIPC, which unlike Ministry sign-off, needs an option (defaulted to yes) where any redlines that have s. 14 will be redacted. Scenarios 6-10 should cover this for the most part.
cc @lmullane
Refinement Questions for 4169 and 4170
FE and BE changes needed. Dev team will come up with better estimates and refinement after the above.
Follow up notes:
@JHarrietha-AOT Hey! Do these updates match your new flow/language?
No designs - this is validations for what should and should not happen appear for Redline - UI will be the same as precious redline processes
Refinement Comments: when can IAO download the redline? is there any extra validation needed? - Not needed. Default validation is enough. New dropdown value for the stitching - Redline for OIPC Review
This has an open question on when to copy the redactions from redline to OIPC. Listed are the options
In correspondence to discussion on 04 Dec with @JHarrietha-AOT
Suggestion : Can we make this option font color little darker. It looks like disabled; whereas it is not. @JHarrietha-AOT @KyEggleston
Suggestion : Can we make this option font color little darker. It looks like disabled; whereas it is not. @JHarrietha-AOT @KyEggleston
I don't see why this couldn't be darker font. Provided all the conditions are met to produce an OIPC redline, it can share the colour/HEX as other active options (e.g., same as the active 'Redline for Sign Off' option in the image below):
Scenario 10 is failing . Able to edit when we switch to 'Redline' layer after OIPC layer is created. Also scenario 11 failing, "Redline for sign off" button is enabled. @sumathi-thirumani-aot could you please check?
Assumptions & Scope This ticket reflects a new type of response package that can be created when an OIPC review layer has been added. the user must be on the OIPC review layer to have this option.
Other types of response packages will remain the same, and follow existing rules (Eg - Redline for Ministry Sign-Off and Response package for applicant.
What is IN scope? New Option for Creating a Type of Response Package - Redline for OIPC
What is NOT in scope? OIPC complaints such as:
Acceptance Criteria
Scenario 1: Creating an OIPC Review Layer
*Scenario 2: Creating an OIPC Review Layer**
Scenario 3: Adding an OIPC Review Layer
Scenario 4: Not adding an OIPC Review Layer
Scenario 5: Copying severing from Redline to OIPC Review Layer
Scenario 6: Changing severing on OIPC Layer
Scenario 7: Preparing an OIPC Review Layer to send to the OIPC
Scenario 8: Preparing an OIPC Review Layer to send to the OIPC that contains s.14
Scenario 9: Creating OIPC Review Package
Scenario 10: Redline locked when OIPC Review Layer created
Scenario 11: No Redline PDF can be created when OIPC Review Layer created
Scenario 12: Choosing not to prepare an OIPC Review Layer to send to the OIPC
Scenario 13: Cancelling OIPC Review Package
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design @xxx - please link the Design here
Definition of Ready
Definition of Done