search

bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Redline as one consolidated PDF #4514

Closed lmullane closed 1 year ago

lmullane commented 1 year ago

Assumptions & Scope What are the assumptions for this story?

Assumption is that all redlines are split by division by default

What is IN scope? Stitching redline PDF into one consolidated PDF for public bodies that have that configuration

What is NOT in scope?

Acceptance Criteria

Scenario 1: PSA or LDB

Scenario 2: Not PSA or LDB GIVEN I am a ministry coordinator or IAO analyst

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
lmullane commented 1 year ago

@JHarrietha-AOT , we may need a design if this is a user choice between whether to split redline by division or to consolidate the redline into one PDF.

@m-prodan, one of the improvements for ministry reviewers is to split redline by division, so perhaps the default should be that unless the coordinator changes the default?

lmullane commented 1 year ago

@abin-aot to connect with @richard-aot

This should be a configuration by ORG code in the front-end, not a user choice in the UI for each download. No design is required.

abin-aot commented 1 year ago

@lmullane : Could you please update the ticket description and AC , to avoid radio button

lmullane commented 1 year ago

@abin-aot , please review the updates.

KyEggleston commented 1 year ago

Ministry of Agriculture (AGR) raised that they would also like to be set up so that they receive the redline as a single whole document, rather than separated into parts by division. Assume this wouldn't be a problem?

cc: @lmullane @m-prodan @sumathi-thirumani-aot

m-prodan commented 1 year ago

Finance (FIN) has indicated the same. I expect some of the Economy Sector would like to as well, but I will await final word from the ECON team.

Matt

KyEggleston commented 1 year ago

@sumathi-thirumani-aot FIN, JED, LBR, MUNI and TACS all confirmed they want the redline as one consolidated PDF.

So the list now for ministries wanting this configuration is:

sumathi-thirumani commented 1 year ago

Above given list is configured in test-marshal. Please note we will be using the bcgovcode representation of ministries in configuration. List maintained in system drafted for reference AGR,LDB,PSA,FIN,JED,LBR,MUNI,TACS

@KyEggleston

KyEggleston commented 1 year ago

Consolidated Redline PDF is generated, and it is organized by modified date (matching page organization in Harms Package, and the 'Modified Date' page ordering in the Redaction App). Therefore, this passes, and closing ticket.