Open m-prodan opened 8 months ago
@liseandtea @m-prodan - I think this needs to be reviewed to be consistent with #4170 and #4169 as well, as some of these ACs don't appear to be consistent with the new approach.
Refinement Comments:
Need confirmation whether this should follow the concept of "Generate as single document" for all ministries or only for configured ministries. ? @JHarrietha-AOT
@sumathi-thirumani-aot - here is how I believe this functionality was expected to work:
When creating a redline for sign off (when the 'OIPC' review layer is created/selected) - captured under #4170 :
When creating a redline for OIPC review (when the 'OIPC' review layer is created/selected) - captured under #4169:
Discussed with @sumathi-thirumani-aot.
The ACs for this ticket, along with the other linked/related OIPC stories, created some confusion around how the OIPC process/workflow should function in regard to creating and downloading an (OIPC) redline for sign off, and a redline for OIPC review.
My previous comment above (from an hour ago) indicates what the expected functionality was. However, due to some confusion based on the ACs, a separate 'OIPC Redline for Sign Off' button will/has been added to the Redaction App. In addition, a 'Download OIPC Redline for Sign Off' button will/has been added in the 'Records' tab.
The 'OIPC Redline for Sign Off' would be produced based on how the ministry is currently configured to receive redlines (either by division or as a consolidated PDF).
The 'Redline for OIPC Review' option in the Redaction App, and the 'Download OIPC Redline for OIPC Review' in the 'Records' tab, are both consistent / correct. Note that this will always be produced as one, consolidated PDF.
For QA, will we QA based on the currently built functionality (as indicated in this comment), which may differ from the ACs. If this functionality works well, it may be the better option to continue with (rather than going back to the original plan). In that case, we will want to update the ACs.
If we reuse the 'Redline for Sign Off' or 'Download Redline for Sign Off' functions for (OIPC) redlines as well, this will overwrite any previous redline created, which may not be ideal from a record-keeping standpoint.
cc: @nimya-aot
@sumathi-thirumani-aot - discussed and agreed at standup adding hover over tooltip to display the last created date for the various packages listed under the 'Download' option in the Records tab. This would work similar to hovering over a Request # in Request Queue. This would allow analysts to see when various package were last created
@KyEggleston This has been completed and has been pushed to test-rook
Assumptions & Scope What are the assumptions for this story?
OIPC Redline for Ministry Sign-off will include all information unredacted, with redlines around the proposed redactions.
OIPC redline for OIPC review will include all information unredacted, EXCEPT for anything that is tagged for s. 14 - that information must be redacted.
Both OIPC Redline for Review and OIPC Redline for Ministry sign-off will NOT contain any pages flagged as Not Responsive of Duplicate
Ministry coordinator will not have access to the Record Review app; download of the redline will be triggered from the Records log.
IAO analysts can also download the redline records package.
The Records log filters are independent of the download. Applying a filter (e.g.by a divisional, error, etc. tag) on the Records Log will have no impact on what is downloaded.
When downloading a redline for Ministry sign-off you will get a ZIP file with one consolidated PDF for each Division. For example, if 4 divisions provided records there will be 4 redline PDFs in the ZIP file.
When downloading a redline for OIPC review, you will get a zip file with a single consolidated PDF
The ZIP file will also contain all the incompatible file types (i.e. non-PDFs), such as audio and GIS files.
What is IN scope?
Download the redline Records Package
What is NOT in scope?
Acceptance Criteria
Scenario 1: Active "Download Redline for Sign Off"
Scenario 2: "Download Redline for Sign Off" by Division
Scenario 3: Inactive "Download Redline for Sign Off"
Scenario 4: Download Redline for Sign-Off - Error
Scenario 5: Download Redline for Sign-Off - Only Incompatible Files
Scenario 6: Active "Download Redline for OIPC Review"
Scenario 7: "Download Redline for OIPC Review
Scenario 8: Inactive "Download Redline for OIPC Review"
Scenario 9: Download Redline for OIPC Review - Error
Scenario 10: Download Redline for OIPC Review - Incompatible Files
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design @xxx - please link the Design here
Definition of Ready
Definition of Done
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)