search

bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
4 stars 3 forks source link

Section number missing on the Redline pdf package for 'with held in full' flag #4655

Open nimya-aot opened 8 months ago

nimya-aot commented 8 months ago

Describe the bug in current situation Section number is missing on Redline pdf if the page is flagged as 'Withheld in full"

Link bug to the User Story

Impact of this bug Describe the impact, i.e. what the impact is, and number of users impacted.

Chance of Occurring (high/medium/low/very low)

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps? request EDU-2023-14311027 on Test-marshal

Steps to Reproduce Steps to reproduce the behavior:

  1. Go to any request and upload a document on records tab
  2. Go to redaction app
  3. Mark one page with 'with held in full' flag
  4. Generate Redline pdf
  5. See error
  6. Section number is missing on that page which is marked with flag 'Withheld in full'

Actual/ observed behaviour/ results

Expected behaviour A clear and concise description of what you expected to happen. Use the gherking language.

Screenshots/ Visual Reference/ Source If applicable, add screenshots to help explain your problem. You an use screengrab. Private Zenhub Image

Private Zenhub Image

nkan-aot commented 8 months ago

This seems to be an issue to this specific request. If I add another full page redaction in the same document, the same issue occurs. However if I download the document and upload to a different request, and add a full page redaction on the same page, then the issue is not there. See https://test-reviewer-web-marshal.apps.silver.devops.gov.bc.ca/foi/729

nimya-aot commented 8 months ago

@abin-aot Reproduced the same issue on another request EDU-2023-09201031 on test-marshal. https://test-reviewer-web-marshal.apps.silver.devops.gov.bc.ca/foi/730

sumathi-thirumani commented 8 months ago

Fixed as part of PR https://github.com/bcgov/foi-docreviewer/pull/604

sumathi-thirumani commented 8 months ago

Pages with different page sizes are having this issue. This is specific to certain documents and expected to be fixed by PDFTron of 10.6. A seperate request is created for it for tracking -> https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/issues/gh/bcgov/foi-flow/4692. Please link it.