Remove Master Data ENUM Identifier and use Data labelling

[abin-aot]

Title of ticket:

Description

The purpose of this ticket is to remove, clean and optimize the way we use Master Data related ENUMs on the FOI FLOW , Document Reviewer code components. The idea is to avoid using AUTO GENERATED ID s on the ENUM, and use the DATA LABEL and/or CODE on ENUM, CONSTANTS - so while running BE migrating script if the next expected available value is not generated, then it should not break code and/or avoid updating IDs into the DB tables to match the sequence. Can discuss more in details!

Dependencies

Are there any dependencies?

DOD

• [x] Analyze the code components - back end and front end on FOI FLOW and DOI DOCREVIEWER - List down the ENUM, Constants with Database ID references. Say like - Request statuses , Notification Types etc.
• [x] Implement a design based on a DATA LABEL COLUMN on the source tables. TBD cc: @abin-aot ! [FOIRequestStatuses, FOIMinistryRequests, FOIRawRequests, FOIRequestTeams]
• [x] Implement a design based on a DATA LABEL COLUMN on the source tables. TBD cc: @abin-aot ! [NotificationTypes, NotificationUserTypes, FOIRequestNotification, FOIRequestNotificationUser]
• [x] Implement a design based on a DATA LABEL COLUMN for view (v_FOIRequests)
• [x] Implement a design based on a DATA LABEL COLUMN for view (v_FOIRequestsNotification / NotuficationUsers)
• [x] Create migration script to add value for DATA LABELING [FOIRequestStatuses, FOIMinistryRequests, FOIRawRequests, FOIRequestTeams]
• [x] Create migration script to add value for DATA LABELING [NotificationTypes, NotificationUserTypes, FOIRequestNotification, FOIRequestNotificationUser]
• [x] Create migration script to add value for DATA LABELING for the view (v_FOIRequests)
• [x] Create migration script to add value for DATA LABELING for the view (v_FOIRequestsNotification / NotuficationUsers)
• [x] Update ENUM, Constants and/or where ever references of IDs from Databases.
• [x] Update ENUM, Constants and/or where ever references of IDs from Databases. (Notification / NotificationUsers)
• [x] List, analyze and plan the test coverage and inform the team!
• [ ] Test IAO and Ministry level state changes including the fee WF
• [ ] Integration testing, Unit testing of the entire application and its related services.

[abin-aot]

@divyav-aot , @antsand : Please wait for 9.2 to release to complete to push to test-marshal

[divyav-aot]

File "/app/request_api/services/events/state.py", line 110, in __commentmessage comment = comment + f". Approved by {signgoffapproval['approvername']}, {signgoffapproval['approvertitle']} on {signgoffapproval['approveddate']}" TypeError: 'NoneType' object is not subscriptable above error also fixed as part of this ticket.

[divyav-aot]

Further improvement can be added for below components. This can be taken as another tech debt. foi-flow: DivisionalStages foi-docreviewer: DocumentPageFlags

[divyav-aot]

Increasing the effort as it includes more changes and e2e testing.

[nimya-aot]

Did regression testing. Noticed that Event queue is not working. Need to fix that. @antsand

[divyav-aot]

@nimya-aot event queue issue is fixed. please retest and let us know.

[nimya-aot]

@divyav-aot its working now