Dupe of issue 205, but I could not follow how to fix it. Invalid interpolation format for "environment" option in service "agri-agent"

bcgov / greenlight

A demonstration of the verifiable organization network showing a new restaurant gathering the permits necessary to open.

Apache License 2.0

34 stars 45 forks source link

Dupe of issue 205, but I could not follow how to fix it. Invalid interpolation format for "environment" option in service "agri-agent" #222

Closed Eirikur closed 5 years ago

Eirikur commented 5 years ago

I'm a developer, but new to this, and I've failed to figure this out. This is what I see when I cd to the docker directory and build. ./manage build

Building agent and wallet containers ... docker-compose --verbose build agent-wallet-db agri-agent bcreg-agent ministry-finance-agent city-surrey-agent fraser-valley-agent liquor-control-agent worksafe-agent compose.config.config.find: Using configuration files: ./docker-compose.yml ERROR: compose.cli.main.main: Invalid interpolation format for "environment" option in service "agri-agent": "${TOB_API_URL:-}"

Eirikur commented 5 years ago

I could not find the trailing $ that is mentioned in the fix that closed 205, but I have the problem.

swcurran commented 5 years ago

Odd. I never did figure out what the fix was for 205 - I did not find a trailing space either. What OS are you running this on? We'll see if we can figure it out. We tend to use Windows, Ubuntu 18.04 and Mac and haven't seen this. @esune - please see what you can dig up.

Eirikur commented 5 years ago

I'm on Linux Mint 19.1, which is based on Ubuntu 18.04.2 they say. This makes it odd that I'm seeing it and you aren't.

esune commented 5 years ago

I'll fire up a Linux box and see what I can find out. It definitely is odd that it would only show up on Linux and not in Git bash...

swcurran commented 5 years ago

Could it be the ":-" option - is that used elsewhere? It's weird that it's docker-compose that seems to have a problem with something. Should be the same on all platforms.

Perhaps there is an environment variable from the system being referenced that has a trailing "$"?

WadeBarnes commented 5 years ago

@Eirikur, Here are a couple of things to try:

Remove the :- from the environment variables where no default option is specified. For example ${TOB_API_URL:-}. I believe some flavors of Linux don't like it.
The file, at least on my Windows box, has CrLf line endings. You may want to try converting them all to Lf line endings.

Please report findings so we can either investigate further or fix the issue. BTW, PRs are always welcome.

Eirikur commented 5 years ago

Thanks Wade! That totally did it. If you'd like a PR, I can do that tonight.

WadeBarnes commented 5 years ago

@Eirikur, You're welcome. Please submit a PR and reference this issue. You did the work, you should get the recognition. Thanks!