bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

fix: ignore ROS if participant is not in my sites #799

Closed fw-noel closed 2 years ago

fw-noel commented 2 years ago

https://freshworks.atlassian.net/browse/HCAP-1304

Basically, my candidates was showing a user who has already gotten ROS for a site I don't have access to and making them actionable. In talking with Tavy, we've determined that if a user gets hired for a site I don't have access to, there can be no further action on that participant.

In this PR, we're doing an inner join which means the participant no longer gets returned if they were ROS'd for a site I don't have access to. This should be okay for now. (Ideally, the participant will be returned with an empty rosStatuses so that they show up and still need to be acknowledged, but I was having some trouble).

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication