bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

HCAP-1319: HAs can see participants in the reports after MoH makes changes #814

Closed alva-fresh closed 2 years ago

alva-fresh commented 2 years ago

https://freshworks.atlassian.net/browse/HCAP-1319

Cause of this bug: additionalEntries are responsible for including participants outside of HAs region in the reports; this can happen due to RoS site change, for example The issue was that it only included entries with status = 'assigned-new-site' - this status is valid when assigning a new site as HA; yet when MoH makes an edit, this status is not being assigned

Proposed fix: Include all edited entries in the report, if they apply to the same health region as HA at any point. This can be done y identifying updated entries: 'data.user <>': 'NULL' and checking if HA is allowed to see them based on region

What else included? Splitting getRosReport into getMohRosMilestonesReport and getHARosMilestonesReport

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication